Page MenuHomePhabricator

Introduce drafts related types and redux actions
ClosedPublic

Authored by marcin on Nov 16 2022, 4:27 AM.
Tags
None
Referenced Files
F3381882: D5643.diff
Thu, Nov 28, 6:57 AM
F3377948: D5643.id18462.diff
Wed, Nov 27, 8:18 AM
Unknown Object (File)
Sun, Nov 24, 6:59 PM
Unknown Object (File)
Sun, Nov 24, 5:30 PM
Unknown Object (File)
Sun, Nov 24, 4:51 PM
Unknown Object (File)
Tue, Nov 19, 2:22 PM
Unknown Object (File)
Tue, Nov 19, 2:22 PM
Unknown Object (File)
Tue, Nov 19, 2:22 PM
Subscribers

Details

Summary

This differential defines types to store drafts in redux and actions to alter them via reducers. Note: setDraftStoreDraftsActionType si define temporarily to increase readability and enhance smooth code review process for this stack. It will be deleted shortly.

Test Plan

Make sure eslint and flow do not point any errors.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-2137
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Important:

Note: setDraftStoreDraftsActionType is defined temporarily to increase readability and enhance smooth code review process for this stack. It will be deleted shortly.

It will be deleted in a differential to get rid of setMessageStoreMessagesActionType and setThreadStoreActionType.

ashoat requested changes to this revision.Nov 16 2022, 7:19 PM

Since the DraftStore should not exist on web, let's keep these files in native

This revision now requires changes to proceed.Nov 16 2022, 7:19 PM

Although maybe we want to add this on web? It didn't exist there before, but now that we have redux-persist on web maybe it is a good idea...

This revision now requires review to proceed.Nov 16 2022, 7:21 PM
This revision is now accepted and ready to land.Nov 17 2022, 11:35 AM

Add remove all drafts store operation