Page MenuHomePhabricator
Differential D5650

Remove CoreData and CoreDataProvider and use draftStore instead
ClosedPublic
Actions

Authored by marcin on Nov 16 2022, 5:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 2:23 PM
Unknown Object (File)
Tue, Nov 19, 2:23 PM
Unknown Object (File)
Tue, Nov 19, 2:23 PM
Unknown Object (File)
Tue, Nov 19, 2:23 PM
Unknown Object (File)
Tue, Nov 19, 2:21 PM
Unknown Object (File)
Tue, Nov 19, 2:11 PM
Unknown Object (File)
Oct 22 2024, 4:35 PM
Unknown Object (File)
Oct 18 2024, 10:28 PM
View All Files
Subscribers
• abosh
ashoat

Details

Reviewers
atul
tomek
Commits
rCOMM38d4d465f8ef: Remove CoreData and CoreDataProvider and use draftStore instead
Summary

This differential removes CoreData and CoredataProvider since they are not necesary. Drafts are now handled via redux

Test Plan

Open the app, write several drafts then kill the app. open app again and make sure drafts look like they were written before app was killed.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-2137
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Nov 16 2022, 5:25 AM
Herald added subscribers: • abosh, ashoat. · View Herald TranscriptNov 16 2022, 5:25 AM
marcin added a parent revision: D5649: Persist drafts in SQLite.Nov 16 2022, 5:26 AM
Harbormaster completed remote builds in B13476: Diff 18475.Nov 16 2022, 5:36 AM
marcin requested review of this revision.Nov 16 2022, 5:36 AM
marcin planned changes to this revision.Nov 17 2022, 2:58 AM
marcin requested review of this revision.Nov 17 2022, 8:23 AM
atul accepted this revision.Nov 17 2022, 3:29 PM

Sweet!

This revision is now accepted and ready to land.Nov 17 2022, 3:29 PM
tomek accepted this revision.Nov 18 2022, 4:05 AM
ashoat added a comment.Nov 18 2022, 4:56 AM

We should make sure to add a diff to the stack to add draftStore to the redux-persist whitelist on web (sorry if you already did this and I missed it!)

marcin added a child revision: D5696: Implement drafts persistence on web.Nov 21 2022, 5:35 AM
marcin updated this revision to Diff 18691.Nov 21 2022, 9:41 AM

Rebase master

Harbormaster completed remote builds in B13644: Diff 18691.Nov 21 2022, 9:55 AM
marcin removed a child revision: D5696: Implement drafts persistence on web.Nov 23 2022, 4:34 AM
marcin added a child revision: D5707: Move ThreadDraftUpdater component to lib.
marcin updated this revision to Diff 18760.Nov 23 2022, 4:56 AM

Rebase before landing

Harbormaster completed remote builds in B13694: Diff 18760.Nov 23 2022, 5:09 AM
Closed by commit rCOMM38d4d465f8ef: Remove CoreData and CoreDataProvider and use draftStore instead (authored by marcin). · Explain WhyNov 23 2022, 5:51 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM38d4d465f8ef: Remove CoreData and CoreDataProvider and use draftStore instead.

Revision Contents
Changeset List

Diff 18475

View Options

native/chat/chat-input-bar.react.js

Loading...
View Options

native/chat/thread-draft-updater.react.js

Loading...
View Options

native/data/core-data-provider.react.js

Loading...
View Options

native/data/core-data.js

Loading...
View Options

native/data/sqlite-context-provider.js

Loading...
View Options

native/root.react.js

Loading...