Linear issue: https://linear.app/comm/issue/ENG-1881/community-navigation-drawer-on-native
In the comments on this issue it has been decided that we'll use the icons from FontAwesome.
Details
Details
Tested with subsequent diffs. I also tested it by displaying it in RelationshipListItem instead of the PencilIcon.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- inka/community_drawer
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/navigation/expand-buttons.react.js | ||
|---|---|---|
| 13 | Please remember to always make all of your types $ReadOnly unless you have a strong reason not to | |
| native/navigation/expand-buttons.react.js | ||
|---|---|---|
| 16–64 ↗ | (On Diff #18828) | We have a lot of duplication here. We could make a single component that accepts a prop telling which icon to show and if the touchable is enabled, but that isn't too beneficial for ExpandButtonDisabled case. So instead, how about having two components: one for disabled and one for other cases? This component would have a prop e.g. "expended" | "collapsed" and would choose the icon based on that. |
| 20–22 ↗ | (On Diff #18828) | Why do have an additional View here? |
| native/themes/colors.js | ||
| 158–159 ↗ | (On Diff #18828) | Should we also add values with these keys to light object? |