Page MenuHomePhabricator
Differential D5707

Move ThreadDraftUpdater component to lib
ClosedPublic
Actions

Authored by marcin on Nov 23 2022, 4:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 10, 7:49 AM
Unknown Object (File)
Wed, Apr 9, 7:00 AM
Unknown Object (File)
Thu, Mar 27, 5:09 AM
Unknown Object (File)
Sun, Mar 16, 10:05 AM
Unknown Object (File)
Sun, Mar 16, 10:05 AM
Unknown Object (File)
Sun, Mar 16, 10:05 AM
Unknown Object (File)
Sun, Mar 16, 10:05 AM
Unknown Object (File)
Sun, Mar 16, 9:54 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
tomek
ashoat
Commits
rCOMM7bb74f07807f: Move ThreadDraftUpdater component to lib
Summary

This differential moves ThreadDraftUpdater component to lib, so that it can be used on web app as well.

Test Plan

Draft moving functionality should remain on native. Open web app and native app on the same clien. Start typing message on the sidebar on native, then create the same sidebar on web. Draft should still be visible on native.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Nov 23 2022, 4:29 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 23 2022, 4:29 AM
marcin updated this revision to Diff 18751.Nov 23 2022, 4:31 AM

Rebase to update commit message

marcin added a child revision: D5696: Implement drafts persistence on web.Nov 23 2022, 4:34 AM
marcin added a parent revision: D5650: Remove CoreData and CoreDataProvider and use draftStore instead.
Harbormaster completed remote builds in B13684: Diff 18750.Nov 23 2022, 4:43 AM
Harbormaster completed remote builds in B13685: Diff 18751.
marcin requested review of this revision.Nov 23 2022, 4:44 AM
marcin added a reviewer: tomek.Nov 23 2022, 5:07 AM
ashoat accepted this revision.Nov 23 2022, 7:22 AM
This revision is now accepted and ready to land.Nov 23 2022, 7:22 AM
tomek accepted this revision.Nov 23 2022, 7:58 AM
marcin updated this revision to Diff 18826.Nov 25 2022, 1:12 AM

Rebase before landing

Harbormaster completed remote builds in B13743: Diff 18826.Nov 25 2022, 1:25 AM
Closed by commit rCOMM7bb74f07807f: Move ThreadDraftUpdater component to lib (authored by marcin). · Explain WhyNov 25 2022, 2:33 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM7bb74f07807f: Move ThreadDraftUpdater component to lib.

Revision Contents
Changeset List

PathSize
lib/
components/
native/
chat/
11 lines
native/
chat/
2 lines

Diff 18826

View Options

lib/components/thread-draft-updater.react.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { import {
contentStringForMediaArray, contentStringForMediaArray,
multimediaMessagePreview, multimediaMessagePreview,
shimUploadURI,
} from '../../media/media-utils'; } from '../../media/media-utils';
import type { PlatformDetails } from '../../types/device-types'; import type { PlatformDetails } from '../../types/device-types';
import type { Media, Video, Image } from '../../types/media-types';
import { import {
messageTypes, messageTypes,
assertMessageType, assertMessageType,
isMediaMessageType, isMediaMessageType,
} from '../../types/message-types'; } from '../../types/message-types';
import type { import type {
MessageInfo, MessageInfo,
RawMessageInfo, RawMessageInfo,
RawMultimediaMessageInfo,
ClientDBMessageInfo, ClientDBMessageInfo,
} from '../../types/message-types'; } from '../../types/message-types';
import type { import type {
ImagesMessageData, ImagesMessageData,
RawImagesMessageInfo, RawImagesMessageInfo,
ImagesMessageInfo, ImagesMessageInfo,
} from '../../types/messages/images'; } from '../../types/messages/images';
import type { import type {
▲ Show 20 Lines • Show All 168 Lines • ▼ Show 20 Lines ): RawMediaMessageInfo | RawImagesMessageInfo {
} }
}, },
shimUnsupportedMessageInfo( shimUnsupportedMessageInfo(
rawMessageInfo: RawMediaMessageInfo | RawImagesMessageInfo, rawMessageInfo: RawMediaMessageInfo | RawImagesMessageInfo,
platformDetails: ?PlatformDetails, platformDetails: ?PlatformDetails,
): RawMediaMessageInfo | RawImagesMessageInfo | RawUnsupportedMessageInfo { ): RawMediaMessageInfo | RawImagesMessageInfo | RawUnsupportedMessageInfo {
if (rawMessageInfo.type === messageTypes.IMAGES) { if (rawMessageInfo.type === messageTypes.IMAGES) {
const shimmedRawMessageInfo = shimMediaMessageInfo( return rawMessageInfo;
rawMessageInfo,
platformDetails,
);
return shimmedRawMessageInfo;
} else { } else {
ashoatUnsubmitted
Not Done
Inline Actions

Nit – I would remove this else block... the if has a return, so the else isn't necessary

ashoat: Nit – I would remove this `else` block... the `if` has a `return`, so the `else` isn't…
rohanAuthorUnsubmitted
Done
Inline Actions

Do you have a preference on merging the if statements or keeping the logic separate?

if (rawMessageInfo.type === messageTypes.IMAGES) {
  return rawMessageInfo;
}
if (hasMinCodeVersion(platformDetails, 158)) {
  return rawMessageInfo;
}

vs.

if (rawMessageInfo.type === messageTypes.IMAGES || hasMinCodeVersion(platformDetails, 158)) {
  return rawMessageInfo;
}
rohan: Do you have a preference on merging the if statements or keeping the logic separate? ```…
ashoatUnsubmitted
Not Done
Inline Actions

No strong preference. I would probably keep the former personally but I'm okay either way

ashoat: No strong preference. I would probably keep the former personally but I'm okay either way
const shimmedRawMessageInfo = shimMediaMessageInfo(
rawMessageInfo,
platformDetails,
);
// TODO figure out first native codeVersion supporting video playback // TODO figure out first native codeVersion supporting video playback
ashoatUnsubmitted
Not Done
Inline Actions

I think we can remove this TODO, right @atul?

ashoat: I think we can remove this `TODO`, right @atul?
atulUnsubmitted
Not Done
Inline Actions

Yes, sorry I should have remove that earlier.

atul: Yes, sorry I should have remove that earlier.
if (hasMinCodeVersion(platformDetails, 158)) { if (hasMinCodeVersion(platformDetails, 158)) {
return shimmedRawMessageInfo; return rawMessageInfo;
} }
const { id } = shimmedRawMessageInfo; const { id } = rawMessageInfo;
invariant(id !== null && id !== undefined, 'id should be set on server'); invariant(id !== null && id !== undefined, 'id should be set on server');
return { return {
type: messageTypes.UNSUPPORTED, type: messageTypes.UNSUPPORTED,
id, id,
threadID: shimmedRawMessageInfo.threadID, threadID: rawMessageInfo.threadID,
creatorID: shimmedRawMessageInfo.creatorID, creatorID: rawMessageInfo.creatorID,
time: shimmedRawMessageInfo.time, time: rawMessageInfo.time,
robotext: multimediaMessagePreview(shimmedRawMessageInfo), robotext: multimediaMessagePreview(rawMessageInfo),
unsupportedMessageInfo: shimmedRawMessageInfo, unsupportedMessageInfo: rawMessageInfo,
}; };
} }
}, },
unshimMessageInfo( unshimMessageInfo(
unwrapped: RawMediaMessageInfo | RawImagesMessageInfo, unwrapped: RawMediaMessageInfo | RawImagesMessageInfo,
messageInfo: RawMessageInfo, messageInfo: RawMessageInfo,
): ?RawMessageInfo { ): ?RawMessageInfo {
▲ Show 20 Lines • Show All 71 Lines • ▼ Show 20 Lines ): string {
); );
}, },
generatesNotifs: async () => pushTypes.NOTIF, generatesNotifs: async () => pushTypes.NOTIF,
includedInRepliesCount: true, includedInRepliesCount: true,
}); });
function shimMediaMessageInfo(
rawMessageInfo: RawMultimediaMessageInfo,
platformDetails: ?PlatformDetails,
): RawMultimediaMessageInfo {
if (rawMessageInfo.type === messageTypes.IMAGES) {
let uriChanged = false;
const newMedia: Image[] = [];
for (const singleMedia of rawMessageInfo.media) {
const shimmedURI = shimUploadURI(singleMedia.uri, platformDetails);
if (shimmedURI === singleMedia.uri) {
newMedia.push(singleMedia);
} else {
newMedia.push(({ ...singleMedia, uri: shimmedURI }: Image));
uriChanged = true;
}
}
if (!uriChanged) {
return rawMessageInfo;
}
return ({
...rawMessageInfo,
media: newMedia,
}: RawImagesMessageInfo);
} else {
let uriChanged = false;
const newMedia: Media[] = [];
for (const singleMedia of rawMessageInfo.media) {
const shimmedURI = shimUploadURI(singleMedia.uri, platformDetails);
if (shimmedURI === singleMedia.uri) {
newMedia.push(singleMedia);
} else if (singleMedia.type === 'photo') {
newMedia.push(({ ...singleMedia, uri: shimmedURI }: Image));
uriChanged = true;
} else {
newMedia.push(({ ...singleMedia, uri: shimmedURI }: Video));
uriChanged = true;
}
}
if (!uriChanged) {
return rawMessageInfo;
}
return ({
...rawMessageInfo,
media: newMedia,
}: RawMediaMessageInfo);
}
}
// Four photos were uploaded before dimensions were calculated server-side, // Four photos were uploaded before dimensions were calculated server-side,
// and delivered to clients without dimensions in the MultimediaMessageInfo. // and delivered to clients without dimensions in the MultimediaMessageInfo.
const preDimensionUploads = { const preDimensionUploads = {
'156642': { width: 1440, height: 1080 }, '156642': { width: 1440, height: 1080 },
'156649': { width: 720, height: 803 }, '156649': { width: 720, height: 803 },
'156794': { width: 720, height: 803 }, '156794': { width: 720, height: 803 },
'156877': { width: 574, height: 454 }, '156877': { width: 574, height: 454 },
}; };
View Options

native/chat/chat.react.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { import {
contentStringForMediaArray, contentStringForMediaArray,
multimediaMessagePreview, multimediaMessagePreview,
shimUploadURI,
} from '../../media/media-utils'; } from '../../media/media-utils';
import type { PlatformDetails } from '../../types/device-types'; import type { PlatformDetails } from '../../types/device-types';
import type { Media, Video, Image } from '../../types/media-types';
import { import {
messageTypes, messageTypes,
assertMessageType, assertMessageType,
isMediaMessageType, isMediaMessageType,
} from '../../types/message-types'; } from '../../types/message-types';
import type { import type {
MessageInfo, MessageInfo,
RawMessageInfo, RawMessageInfo,
RawMultimediaMessageInfo,
ClientDBMessageInfo, ClientDBMessageInfo,
} from '../../types/message-types'; } from '../../types/message-types';
import type { import type {
ImagesMessageData, ImagesMessageData,
RawImagesMessageInfo, RawImagesMessageInfo,
ImagesMessageInfo, ImagesMessageInfo,
} from '../../types/messages/images'; } from '../../types/messages/images';
import type { import type {
▲ Show 20 Lines • Show All 168 Lines • ▼ Show 20 Lines ): RawMediaMessageInfo | RawImagesMessageInfo {
} }
}, },
shimUnsupportedMessageInfo( shimUnsupportedMessageInfo(
rawMessageInfo: RawMediaMessageInfo | RawImagesMessageInfo, rawMessageInfo: RawMediaMessageInfo | RawImagesMessageInfo,
platformDetails: ?PlatformDetails, platformDetails: ?PlatformDetails,
): RawMediaMessageInfo | RawImagesMessageInfo | RawUnsupportedMessageInfo { ): RawMediaMessageInfo | RawImagesMessageInfo | RawUnsupportedMessageInfo {
if (rawMessageInfo.type === messageTypes.IMAGES) { if (rawMessageInfo.type === messageTypes.IMAGES) {
const shimmedRawMessageInfo = shimMediaMessageInfo( return rawMessageInfo;
rawMessageInfo,
platformDetails,
);
return shimmedRawMessageInfo;
} else { } else {
ashoatUnsubmitted
Not Done
Inline Actions

Nit – I would remove this else block... the if has a return, so the else isn't necessary

ashoat: Nit – I would remove this `else` block... the `if` has a `return`, so the `else` isn't…
rohanAuthorUnsubmitted
Done
Inline Actions

Do you have a preference on merging the if statements or keeping the logic separate?

if (rawMessageInfo.type === messageTypes.IMAGES) {
  return rawMessageInfo;
}
if (hasMinCodeVersion(platformDetails, 158)) {
  return rawMessageInfo;
}

vs.

if (rawMessageInfo.type === messageTypes.IMAGES || hasMinCodeVersion(platformDetails, 158)) {
  return rawMessageInfo;
}
rohan: Do you have a preference on merging the if statements or keeping the logic separate? ```…
ashoatUnsubmitted
Not Done
Inline Actions

No strong preference. I would probably keep the former personally but I'm okay either way

ashoat: No strong preference. I would probably keep the former personally but I'm okay either way
const shimmedRawMessageInfo = shimMediaMessageInfo(
rawMessageInfo,
platformDetails,
);
// TODO figure out first native codeVersion supporting video playback // TODO figure out first native codeVersion supporting video playback
ashoatUnsubmitted
Not Done
Inline Actions

I think we can remove this TODO, right @atul?

ashoat: I think we can remove this `TODO`, right @atul?
atulUnsubmitted
Not Done
Inline Actions

Yes, sorry I should have remove that earlier.

atul: Yes, sorry I should have remove that earlier.
if (hasMinCodeVersion(platformDetails, 158)) { if (hasMinCodeVersion(platformDetails, 158)) {
return shimmedRawMessageInfo; return rawMessageInfo;
} }
const { id } = shimmedRawMessageInfo; const { id } = rawMessageInfo;
invariant(id !== null && id !== undefined, 'id should be set on server'); invariant(id !== null && id !== undefined, 'id should be set on server');
return { return {
type: messageTypes.UNSUPPORTED, type: messageTypes.UNSUPPORTED,
id, id,
threadID: shimmedRawMessageInfo.threadID, threadID: rawMessageInfo.threadID,
creatorID: shimmedRawMessageInfo.creatorID, creatorID: rawMessageInfo.creatorID,
time: shimmedRawMessageInfo.time, time: rawMessageInfo.time,
robotext: multimediaMessagePreview(shimmedRawMessageInfo), robotext: multimediaMessagePreview(rawMessageInfo),
unsupportedMessageInfo: shimmedRawMessageInfo, unsupportedMessageInfo: rawMessageInfo,
}; };
} }
}, },
unshimMessageInfo( unshimMessageInfo(
unwrapped: RawMediaMessageInfo | RawImagesMessageInfo, unwrapped: RawMediaMessageInfo | RawImagesMessageInfo,
messageInfo: RawMessageInfo, messageInfo: RawMessageInfo,
): ?RawMessageInfo { ): ?RawMessageInfo {
▲ Show 20 Lines • Show All 71 Lines • ▼ Show 20 Lines ): string {
); );
}, },
generatesNotifs: async () => pushTypes.NOTIF, generatesNotifs: async () => pushTypes.NOTIF,
includedInRepliesCount: true, includedInRepliesCount: true,
}); });
function shimMediaMessageInfo(
rawMessageInfo: RawMultimediaMessageInfo,
platformDetails: ?PlatformDetails,
): RawMultimediaMessageInfo {
if (rawMessageInfo.type === messageTypes.IMAGES) {
let uriChanged = false;
const newMedia: Image[] = [];
for (const singleMedia of rawMessageInfo.media) {
const shimmedURI = shimUploadURI(singleMedia.uri, platformDetails);
if (shimmedURI === singleMedia.uri) {
newMedia.push(singleMedia);
} else {
newMedia.push(({ ...singleMedia, uri: shimmedURI }: Image));
uriChanged = true;
}
}
if (!uriChanged) {
return rawMessageInfo;
}
return ({
...rawMessageInfo,
media: newMedia,
}: RawImagesMessageInfo);
} else {
let uriChanged = false;
const newMedia: Media[] = [];
for (const singleMedia of rawMessageInfo.media) {
const shimmedURI = shimUploadURI(singleMedia.uri, platformDetails);
if (shimmedURI === singleMedia.uri) {
newMedia.push(singleMedia);
} else if (singleMedia.type === 'photo') {
newMedia.push(({ ...singleMedia, uri: shimmedURI }: Image));
uriChanged = true;
} else {
newMedia.push(({ ...singleMedia, uri: shimmedURI }: Video));
uriChanged = true;
}
}
if (!uriChanged) {
return rawMessageInfo;
}
return ({
...rawMessageInfo,
media: newMedia,
}: RawMediaMessageInfo);
}
}
// Four photos were uploaded before dimensions were calculated server-side, // Four photos were uploaded before dimensions were calculated server-side,
// and delivered to clients without dimensions in the MultimediaMessageInfo. // and delivered to clients without dimensions in the MultimediaMessageInfo.
const preDimensionUploads = { const preDimensionUploads = {
'156642': { width: 1440, height: 1080 }, '156642': { width: 1440, height: 1080 },
'156649': { width: 720, height: 803 }, '156649': { width: 720, height: 803 },
'156794': { width: 720, height: 803 }, '156794': { width: 720, height: 803 },
'156877': { width: 574, height: 454 }, '156877': { width: 574, height: 454 },
}; };
View Options

native/chat/thread-draft-updater.react.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { import {
contentStringForMediaArray, contentStringForMediaArray,
multimediaMessagePreview, multimediaMessagePreview,
shimUploadURI,
} from '../../media/media-utils'; } from '../../media/media-utils';
import type { PlatformDetails } from '../../types/device-types'; import type { PlatformDetails } from '../../types/device-types';
import type { Media, Video, Image } from '../../types/media-types';
import { import {
messageTypes, messageTypes,
assertMessageType, assertMessageType,
isMediaMessageType, isMediaMessageType,
} from '../../types/message-types'; } from '../../types/message-types';
import type { import type {
MessageInfo, MessageInfo,
RawMessageInfo, RawMessageInfo,
RawMultimediaMessageInfo,
ClientDBMessageInfo, ClientDBMessageInfo,
} from '../../types/message-types'; } from '../../types/message-types';
import type { import type {
ImagesMessageData, ImagesMessageData,
RawImagesMessageInfo, RawImagesMessageInfo,
ImagesMessageInfo, ImagesMessageInfo,
} from '../../types/messages/images'; } from '../../types/messages/images';
import type { import type {
▲ Show 20 Lines • Show All 168 Lines • ▼ Show 20 Lines ): RawMediaMessageInfo | RawImagesMessageInfo {
} }
}, },
shimUnsupportedMessageInfo( shimUnsupportedMessageInfo(
rawMessageInfo: RawMediaMessageInfo | RawImagesMessageInfo, rawMessageInfo: RawMediaMessageInfo | RawImagesMessageInfo,
platformDetails: ?PlatformDetails, platformDetails: ?PlatformDetails,
): RawMediaMessageInfo | RawImagesMessageInfo | RawUnsupportedMessageInfo { ): RawMediaMessageInfo | RawImagesMessageInfo | RawUnsupportedMessageInfo {
if (rawMessageInfo.type === messageTypes.IMAGES) { if (rawMessageInfo.type === messageTypes.IMAGES) {
const shimmedRawMessageInfo = shimMediaMessageInfo( return rawMessageInfo;
rawMessageInfo,
platformDetails,
);
return shimmedRawMessageInfo;
} else { } else {
ashoatUnsubmitted
Not Done
Inline Actions

Nit – I would remove this else block... the if has a return, so the else isn't necessary

ashoat: Nit – I would remove this `else` block... the `if` has a `return`, so the `else` isn't…
rohanAuthorUnsubmitted
Done
Inline Actions

Do you have a preference on merging the if statements or keeping the logic separate?

if (rawMessageInfo.type === messageTypes.IMAGES) {
  return rawMessageInfo;
}
if (hasMinCodeVersion(platformDetails, 158)) {
  return rawMessageInfo;
}

vs.

if (rawMessageInfo.type === messageTypes.IMAGES || hasMinCodeVersion(platformDetails, 158)) {
  return rawMessageInfo;
}
rohan: Do you have a preference on merging the if statements or keeping the logic separate? ```…
ashoatUnsubmitted
Not Done
Inline Actions

No strong preference. I would probably keep the former personally but I'm okay either way

ashoat: No strong preference. I would probably keep the former personally but I'm okay either way
const shimmedRawMessageInfo = shimMediaMessageInfo(
rawMessageInfo,
platformDetails,
);
// TODO figure out first native codeVersion supporting video playback // TODO figure out first native codeVersion supporting video playback
ashoatUnsubmitted
Not Done
Inline Actions

I think we can remove this TODO, right @atul?

ashoat: I think we can remove this `TODO`, right @atul?
atulUnsubmitted
Not Done
Inline Actions

Yes, sorry I should have remove that earlier.

atul: Yes, sorry I should have remove that earlier.
if (hasMinCodeVersion(platformDetails, 158)) { if (hasMinCodeVersion(platformDetails, 158)) {
return shimmedRawMessageInfo; return rawMessageInfo;
} }
const { id } = shimmedRawMessageInfo; const { id } = rawMessageInfo;
invariant(id !== null && id !== undefined, 'id should be set on server'); invariant(id !== null && id !== undefined, 'id should be set on server');
return { return {
type: messageTypes.UNSUPPORTED, type: messageTypes.UNSUPPORTED,
id, id,
threadID: shimmedRawMessageInfo.threadID, threadID: rawMessageInfo.threadID,
creatorID: shimmedRawMessageInfo.creatorID, creatorID: rawMessageInfo.creatorID,
time: shimmedRawMessageInfo.time, time: rawMessageInfo.time,
robotext: multimediaMessagePreview(shimmedRawMessageInfo), robotext: multimediaMessagePreview(rawMessageInfo),
unsupportedMessageInfo: shimmedRawMessageInfo, unsupportedMessageInfo: rawMessageInfo,
}; };
} }
}, },
unshimMessageInfo( unshimMessageInfo(
unwrapped: RawMediaMessageInfo | RawImagesMessageInfo, unwrapped: RawMediaMessageInfo | RawImagesMessageInfo,
messageInfo: RawMessageInfo, messageInfo: RawMessageInfo,
): ?RawMessageInfo { ): ?RawMessageInfo {
▲ Show 20 Lines • Show All 71 Lines • ▼ Show 20 Lines ): string {
); );
}, },
generatesNotifs: async () => pushTypes.NOTIF, generatesNotifs: async () => pushTypes.NOTIF,
includedInRepliesCount: true, includedInRepliesCount: true,
}); });
function shimMediaMessageInfo(
rawMessageInfo: RawMultimediaMessageInfo,
platformDetails: ?PlatformDetails,
): RawMultimediaMessageInfo {
if (rawMessageInfo.type === messageTypes.IMAGES) {
let uriChanged = false;
const newMedia: Image[] = [];
for (const singleMedia of rawMessageInfo.media) {
const shimmedURI = shimUploadURI(singleMedia.uri, platformDetails);
if (shimmedURI === singleMedia.uri) {
newMedia.push(singleMedia);
} else {
newMedia.push(({ ...singleMedia, uri: shimmedURI }: Image));
uriChanged = true;
}
}
if (!uriChanged) {
return rawMessageInfo;
}
return ({
...rawMessageInfo,
media: newMedia,
}: RawImagesMessageInfo);
} else {
let uriChanged = false;
const newMedia: Media[] = [];
for (const singleMedia of rawMessageInfo.media) {
const shimmedURI = shimUploadURI(singleMedia.uri, platformDetails);
if (shimmedURI === singleMedia.uri) {
newMedia.push(singleMedia);
} else if (singleMedia.type === 'photo') {
newMedia.push(({ ...singleMedia, uri: shimmedURI }: Image));
uriChanged = true;
} else {
newMedia.push(({ ...singleMedia, uri: shimmedURI }: Video));
uriChanged = true;
}
}
if (!uriChanged) {
return rawMessageInfo;
}
return ({
...rawMessageInfo,
media: newMedia,
}: RawMediaMessageInfo);
}
}
// Four photos were uploaded before dimensions were calculated server-side, // Four photos were uploaded before dimensions were calculated server-side,
// and delivered to clients without dimensions in the MultimediaMessageInfo. // and delivered to clients without dimensions in the MultimediaMessageInfo.
const preDimensionUploads = { const preDimensionUploads = {
'156642': { width: 1440, height: 1080 }, '156642': { width: 1440, height: 1080 },
'156649': { width: 720, height: 803 }, '156649': { width: 720, height: 803 },
'156794': { width: 720, height: 803 }, '156794': { width: 720, height: 803 },
'156877': { width: 574, height: 454 }, '156877': { width: 574, height: 454 },
}; };