(Think it probably makes sense to add @bartek to your Rust diffs even if he doesn't have full context on identity stuff? CC @ashoat @tomek who probably have a better idea)

Don't have context + enough rust knowledge here

change js functions to camelCase

Harbormaster failed remote builds in B13870: Diff 18994!Nov 29 2022, 11:33 PM

varun edited reviewers, added: • jon; removed: atul. varun added 2 blocking reviewer(s): tomek, bartek.Nov 29 2022, 11:35 PM

rebase

Harbormaster completed remote builds in B13875: Diff 18999.Nov 30 2022, 12:01 AM

tomek accepted this revision.Nov 30 2022, 5:27 AM

tomek added inline comments.

keyserver/addons/opaque-ke-node/src/lib.rs
154–177 ↗	(On Diff #18999)	These two seem to be almost identical. Can we somehow share the logic between them?

bartek accepted this revision.Nov 30 2022, 5:44 AM

bartek added inline comments.

keyserver/addons/opaque-ke-node/src/lib.rs

154–177 ↗

(On Diff #18999)

I'm wondering if it would be worth implementing this API in a more object-oriented way.

// in JS, instead of
const startResult = clientLoginStart(...);
const loginStateArray = getLoginStartStateArray(startResult);
const loginMessageArray = getLoginStartMessageArray(startResult);

// do this
const startResult = clientLoginStart(...);
const loginStateArray = startResult.getStateArray();
const loginMessageArray = startResult.getMessageArray();

But not sure how could this affect the complexity/readibility of this code and if it is even convenient to mix JsBox and JsObject

I think the object oriented way is a bit cleaner, especially if everything needs to go through a context object anyway.

Personally I'm not a fan of get in method names, generally it's implied.

This revision is now accepted and ready to land.Nov 30 2022, 11:47 AM

varun added inline comments.Nov 30 2022, 1:00 PM

keyserver/addons/opaque-ke-node/src/lib.rs
154–177 ↗	(On Diff #18999)	I wanted to do this in a more object-oriented way, but I couldn't figure out how to get data from a `JsBox` on the javascript side
154–177 ↗	(On Diff #18999)	These two seem to be almost identical. Can we somehow share the logic between them? Can't think of a good way besides introducing an enum as a function param, but that adds a different kind of complexity... https://linear.app/comm/issue/ENG-2384/improve-the-opaque-ke-node-library

In D5738#172368, @jon wrote:

I think the object oriented way is a bit cleaner, especially if everything needs to go through a context object anyway.

Personally I'm not a fan of get in method names, generally it's implied.

https://linear.app/comm/issue/ENG-2384/improve-the-opaque-ke-node-library

Closed by commit rCOMMcaa99e1a7aa0: [keyserver] APIs for starting client side of PAKE login (authored by varun). · Explain WhyNov 30 2022, 1:04 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMcaa99e1a7aa0: [keyserver] APIs for starting client side of PAKE login.