(Think it probably makes sense to add @bartek to your Rust diffs even if he doesn't have full context on identity stuff? CC @ashoat @tomek who probably have a better idea)

Yeah good call

Don't have context + enough rust knowledge here

tomek added inline comments.Nov 29 2022, 7:26 AM

keyserver/addons/opaque-ke-node/src/lib.rs
94–97 ↗	(On Diff #18880)	Can we avoid shadowing? I think that it reduces maintainability significantly.

tomek added a reviewer: • jon.Nov 29 2022, 7:26 AM

varun added inline comments.Nov 29 2022, 10:51 PM

keyserver/addons/opaque-ke-node/src/lib.rs
94–97 ↗	(On Diff #18880)	sure!

change variable names to avoid shadowing, make js functions camelCase

Harbormaster failed remote builds in B13869: Diff 18993!Nov 29 2022, 11:28 PM

varun removed a reviewer: atul. varun added 3 blocking reviewer(s): • jon, bartek, tomek.Nov 29 2022, 11:35 PM

rebase

Harbormaster completed remote builds in B13874: Diff 18998.Nov 30 2022, 12:01 AM

tomek accepted this revision.Nov 30 2022, 5:18 AM

bartek accepted this revision.Nov 30 2022, 6:07 AM

• jon accepted this revision.Nov 30 2022, 11:47 AM

This revision is now accepted and ready to land.Nov 30 2022, 11:47 AM

Closed by commit rCOMM95ec5c070728: [keyserver] more APIs for finishing client side of PAKE registration (authored by varun). · Explain WhyNov 30 2022, 1:04 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM95ec5c070728: [keyserver] more APIs for finishing client side of PAKE registration.

Revision Contents
Changeset List

Path

Size

keyserver/

addons/

opaque-ke-node/

src/

lib.rs

55 lines

Diff 19040

View Options

keyserver/addons/opaque-ke-node/src/lib.rs

Show First 20 Lines • Show All 1,023 Lines • ▼ Show 20 Lines	): ReduceMessageStoreResult {
) {		) {
const payload = ensureRealizedThreadIDIsUsedWhenPossible(		const payload = ensureRealizedThreadIDIsUsedWhenPossible(
action.payload,		action.payload,
newThreadInfos,		newThreadInfos,
);		);
const { localID, threadID } = payload;		const { localID, threadID } = payload;
invariant(localID, `localID should be set on ${action.type}`);		invariant(localID, `localID should be set on ${action.type}`);

		const messageIDs = messageStore.threads[threadID]?.messageIDs ?? [];
		if (!messageStore.messages[localID]) {
		for (const existingMessageID of messageIDs) {
		const existingMessageInfo = messageStore.messages[existingMessageID];
		if (existingMessageInfo && existingMessageInfo.localID === localID) {
		return { messageStoreOperations: [], messageStore };
		}
		}
		}

const messageStoreOperations = [		const messageStoreOperations = [
{		{
type: 'replace',		type: 'replace',
payload: { id: localID, messageInfo: payload },		payload: { id: localID, messageInfo: payload },
},		},
];		];
const processedMessageStore = processMessageStoreOperations(
messageStore,
messageStoreOperations,
);

const now = Date.now();		const now = Date.now();
const messageIDs = messageStore.threads[threadID]?.messageIDs ?? [];		let updatedThreads;
		let local = { ...messageStore.local };
if (messageStore.messages[localID]) {		if (messageStore.messages[localID]) {
const messages = { ...messageStore.messages, [localID]: payload };		const messages = { ...messageStore.messages, [localID]: payload };
const local = _pickBy(		local = _pickBy(
(localInfo: LocalMessageInfo, key: string) => key !== localID,		(localInfo: LocalMessageInfo, key: string) => key !== localID,
)(messageStore.local);		)(messageStore.local);
const thread = messageStore.threads[threadID];		const thread = messageStore.threads[threadID];
const threads = {		updatedThreads = {
...messageStore.threads,
[threadID]: {		[threadID]: {
messageIDs: sortMessageIDs(messages)(messageIDs),		messageIDs: sortMessageIDs(messages)(messageIDs),
startReached: thread?.startReached ?? true,		startReached: thread?.startReached ?? true,
lastNavigatedTo: thread?.lastNavigatedTo ?? now,		lastNavigatedTo: thread?.lastNavigatedTo ?? now,
lastPruned: thread?.lastPruned ?? now,		lastPruned: thread?.lastPruned ?? now,
},		},
};		};
return {		} else {
messageStoreOperations,		updatedThreads = {
messageStore: {		[threadID]: messageStore.threads[threadID]
...messageStore,
messages: processedMessageStore.messages,
threads,
local,
},
};
}

for (const existingMessageID of messageIDs) {
const existingMessageInfo = messageStore.messages[existingMessageID];
if (existingMessageInfo && existingMessageInfo.localID === localID) {
return { messageStoreOperations: [], messageStore };
}
}

const threadState: ThreadMessageInfo = messageStore.threads[threadID]
? {		? {
...messageStore.threads[threadID],		...messageStore.threads[threadID],
messageIDs: [localID, ...messageIDs],		messageIDs: [localID, ...messageIDs],
}		}
: {		: {
messageIDs: [localID],		messageIDs: [localID],
startReached: true,		startReached: true,
lastNavigatedTo: now,		lastNavigatedTo: now,
lastPruned: now,		lastPruned: now,
		},
};		};
		}

return {		const threads = {
messageStoreOperations,
messageStore: {
messages: processedMessageStore.messages,
threads: {
...messageStore.threads,		...messageStore.threads,
[threadID]: threadState,		...updatedThreads,
		};
		messageStoreOperations.push({
		type: 'replace_threads',
		payload: {
		threads: { ...updatedThreads },
},		},
local: messageStore.local,		});

		const processedMessageStore = processMessageStoreOperations(
		messageStore,
		messageStoreOperations,
		);

		const newMessageStore = {
		messages: processedMessageStore.messages,
		threads,
		local,
currentAsOf: messageStore.currentAsOf,		currentAsOf: messageStore.currentAsOf,
},		};

		assertMessageStoreThreadsAreEqual(
		processedMessageStore,
		newMessageStore,
		action.type,
		);

		return {
		messageStoreOperations,
		messageStore: newMessageStore,
};		};
} else if (		} else if (
action.type === sendTextMessageActionTypes.failed \|\|		action.type === sendTextMessageActionTypes.failed \|\|
action.type === sendMultimediaMessageActionTypes.failed		action.type === sendMultimediaMessageActionTypes.failed
) {		) {
const { localID } = action.payload;		const { localID } = action.payload;
return {		return {
messageStoreOperations: [],		messageStoreOperations: [],
▲ Show 20 Lines • Show All 565 Lines • Show Last 20 Lines

[keyserver] more APIs for finishing client side of PAKE registrationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 19040

keyserver/addons/opaque-ke-node/src/lib.rs

[keyserver] more APIs for finishing client side of PAKE registration
ClosedPublic
Actions

Revision Contents
Changeset List