Page MenuHomePhabricator
Differential D5737

[keyserver] more APIs for finishing client side of PAKE registration
ClosedPublic
Actions

Authored by varun on Nov 28 2022, 7:40 AM.
Tags
None
Referenced Files
F3386411: D5737.diff
Fri, Nov 29, 4:34 AM
Unknown Object (File)
Tue, Nov 26, 10:10 PM
Unknown Object (File)
Fri, Nov 22, 8:01 AM
Unknown Object (File)
Fri, Nov 22, 8:01 AM
Unknown Object (File)
Fri, Nov 22, 8:00 AM
Unknown Object (File)
Fri, Nov 22, 8:00 AM
Unknown Object (File)
Fri, Nov 22, 7:59 AM
Unknown Object (File)
Fri, Nov 22, 7:45 AM
View All Files
Subscribers
ashoat
atul
bartek
tomek

Details

Reviewers
tomek
bartek
• jon
Commits
rCOMM95ec5c070728: [keyserver] more APIs for finishing client side of PAKE registration
Summary

using Neon to surface the Rust opaque-ke "client registration finish" APIs to Node.js

Test Plan

called the new APIs from a Node module and confirmed the results

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Nov 28 2022, 7:40 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptNov 28 2022, 7:40 AM
varun added reviewers: tomek, atul.Nov 28 2022, 7:40 AM
Harbormaster completed remote builds in B13789: Diff 18880.Nov 28 2022, 7:53 AM
varun requested review of this revision.Nov 28 2022, 7:53 AM
varun added a parent revision: D5736: [keyserver] expose APIs to start PAKE registration on client side.Nov 28 2022, 7:56 AM
varun added a child revision: D5738: [keyserver] APIs for starting client side of PAKE login.
atul added a reviewer: bartek.Nov 28 2022, 2:53 PM
atul added a subscriber: bartek.

(Think it probably makes sense to add @bartek to your Rust diffs even if he doesn't have full context on identity stuff? CC @ashoat @tomek who probably have a better idea)

ashoat added a comment.Nov 28 2022, 3:02 PM

Yeah good call

atul resigned from this revision.Nov 28 2022, 3:52 PM

Don't have context + enough rust knowledge here

tomek added inline comments.Nov 29 2022, 7:26 AM
keyserver/addons/opaque-ke-node/src/lib.rs
94–97 ↗(On Diff #18880)

Can we avoid shadowing? I think that it reduces maintainability significantly.

tomek added a reviewer: • jon.Nov 29 2022, 7:26 AM
varun added inline comments.Nov 29 2022, 10:51 PM
keyserver/addons/opaque-ke-node/src/lib.rs
94–97 ↗(On Diff #18880)

sure!

varun updated this revision to Diff 18993.Nov 29 2022, 11:27 PM

change variable names to avoid shadowing, make js functions camelCase

Harbormaster failed remote builds in B13869: Diff 18993!Nov 29 2022, 11:28 PM
varun removed a reviewer: atul. varun added 3 blocking reviewer(s): • jon, bartek, tomek.Nov 29 2022, 11:35 PM
varun updated this revision to Diff 18998.Nov 29 2022, 11:49 PM

rebase

Harbormaster completed remote builds in B13874: Diff 18998.Nov 30 2022, 12:01 AM
tomek accepted this revision.Nov 30 2022, 5:18 AM
bartek accepted this revision.Nov 30 2022, 6:07 AM
• jon accepted this revision.Nov 30 2022, 11:47 AM
This revision is now accepted and ready to land.Nov 30 2022, 11:47 AM
Closed by commit rCOMM95ec5c070728: [keyserver] more APIs for finishing client side of PAKE registration (authored by varun). · Explain WhyNov 30 2022, 1:04 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM95ec5c070728: [keyserver] more APIs for finishing client side of PAKE registration.

Revision Contents
Changeset List

PathSize
keyserver/
addons/
opaque-ke-node/
src/
55 lines

Diff 19040

View Options

keyserver/addons/opaque-ke-node/src/lib.rs

Loading...