keyserver/addons/opaque-ke-node/src/lib.rs
27 ↗	(On Diff #18879)	Why do we name it `params`?
41 ↗	(On Diff #18879)	Why do we need that?
62–63 ↗	(On Diff #18879)	Could you explain what this line does? What is the meaning of `0`?

What's the best place to start reading to have more context on the PAKE stuff? I'd like to have a better overview of what's going on here

keyserver/addons/opaque-ke-node/src/lib.rs
62–63 ↗	(On Diff #18879)	I think 0 means the first argument of a function: https://neon-bindings.com/docs/functions#accessing-arguments So I suspect this gets the first argument, which should be of type `ClientRegistrationStartResult`
83–91 ↗	(On Diff #18879)	Shouldn't we use the `camelCase` for JS function names?

tomek accepted this revision.Nov 29 2022, 7:49 AM

tomek added 1 blocking reviewer(s): bartek.

tomek added inline comments.

keyserver/addons/opaque-ke-node/src/lib.rs
62–63 ↗	(On Diff #18879)	Now it makes a lot more sense!

In D5736#171668, @bartek wrote:

What's the best place to start reading to have more context on the PAKE stuff? I'd like to have a better overview of what's going on here

I think for these diffs this should give you enough context: https://github.com/novifinancial/opaque-ke/blob/v1.2.0/examples/simple_login.rs

This is an example of how OPAQUE is used for login (our use case)

keyserver/addons/opaque-ke-node/src/lib.rs
27 ↗	(On Diff #18879)	to keep things consistent with naming on the Identity service side
41 ↗	(On Diff #18879)	Finalize is executed on the main JavaScript thread and executed immediately before garbage collection. Values contained by a JsBox must implement Finalize. We don't have anything we need to clean up ourselves so we use the default empty implementation
62–63 ↗	(On Diff #18879)	yeah, that's right. sorry, should've annotated this diff
83–91 ↗	(On Diff #18879)	yeah, good point, i'll fix that

change js function names to camelCase

Harbormaster failed remote builds in B13868: Diff 18992!Nov 29 2022, 11:27 PM

rebase

Harbormaster completed remote builds in B13873: Diff 18997.Nov 30 2022, 12:01 AM

bartek accepted this revision.Nov 30 2022, 5:21 AM

I feel like this would be a good candidate to include a unit test. Also demonstrates the ergonomics of "using" the hash method we just introduced.

This revision is now accepted and ready to land.Nov 30 2022, 11:49 AM

In D5736#172373, @jon wrote:

I feel like this would be a good candidate to include a unit test. Also demonstrates the ergonomics of "using" the hash method we just introduced.

https://linear.app/comm/issue/ENG-2383/add-unit-tests-for-hash-function-in-opaque-ke-node

Closed by commit rCOMMb97763fc1082: [keyserver] expose APIs to start PAKE registration on client side (authored by varun). · Explain WhyNov 30 2022, 1:04 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMb97763fc1082: [keyserver] expose APIs to start PAKE registration on client side.