Page MenuHomePhabricator
Differential D5774

Implement bulk JSI call te retrieve all SQLite data
ClosedPublic
Actions

Authored by marcin on Nov 30 2022, 11:29 AM.
Tags
None
Referenced Files
F3500347: D5774.id19097.diff
Fri, Dec 20, 1:17 AM
F3500255: D5774.id19028.diff
Fri, Dec 20, 1:07 AM
F3497807: D5774.diff
Thu, Dec 19, 7:59 PM
Unknown Object (File)
Sat, Dec 14, 12:54 AM
Unknown Object (File)
Mon, Dec 9, 11:45 AM
Unknown Object (File)
Mon, Dec 9, 7:05 AM
Unknown Object (File)
Fri, Nov 22, 6:45 AM
Unknown Object (File)
Fri, Nov 22, 6:45 AM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
kamil
• jon
Commits
rCOMMc07febd01dab: Implement bulk JSI call te retrieve all SQLite data
Summary

This differential implements one JSI call to retrieve SQLite data.

Test Plan

Use this new call instead of separate calls for messages, threads and drafts in SQLiteDataHandler. Ensure in flipper SET_CLIENT_DB_STORE action payload is correct.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-2137
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Nov 30 2022, 11:29 AM
Herald added a reviewer: • jon. · View Herald TranscriptNov 30 2022, 11:29 AM
Herald added a subscriber: ashoat. · View Herald Transcript
marcin added a parent revision: D5773: Refactor getAllThreads{Sync}. Bring db threads parsing into separate function.Nov 30 2022, 11:29 AM
marcin added a child revision: D5775: Use new JSI call in SQLiteDataHandler.Nov 30 2022, 11:34 AM
marcin added a reviewer: kamil.Nov 30 2022, 11:38 AM
Harbormaster completed remote builds in B13888: Diff 19028.Nov 30 2022, 11:41 AM
marcin requested review of this revision.Nov 30 2022, 11:41 AM
• jon resigned from this revision.Nov 30 2022, 11:51 AM

not familiar enough with c++ best practices to provide valuable feedback

I'll edit the herald rules to avoid these files

tomek accepted this revision.Dec 1 2022, 6:19 AM
This revision is now accepted and ready to land.Dec 1 2022, 6:19 AM
marcin updated this revision to Diff 19097.Dec 2 2022, 12:44 AM

Rebase before landing

Harbormaster completed remote builds in B13937: Diff 19097.Dec 2 2022, 12:55 AM
Closed by commit rCOMMc07febd01dab: Implement bulk JSI call te retrieve all SQLite data (authored by marcin). · Explain WhyDec 2 2022, 1:06 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMc07febd01dab: Implement bulk JSI call te retrieve all SQLite data.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
1 line
51 lines
_generated/
schema/
7 lines

Diff 19028

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/NativeModules.h

Loading...
View Options

native/cpp/CommonCpp/_generated/NativeModules.cpp

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...