Remove unecessary JSI queries
ClosedPublic
Actions

Authored by marcin on Nov 30 2022, 11:44 AM.

Details

Reviewers

tomek
atul
• jon

Commits

rCOMM14fe7b7a0c2e: Remove unecessary JSI queries

Summary

This differential removes ol unecessary JSI queries to get all drafts, threads and messages.

Test Plan

Removed queries are not used anymore in the project, so the sufficient test plan is to build the app.

Diff Detail

Repository

rCOMM Comm

Branch

marcin/eng-2137

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Nov 30 2022, 11:44 AM

Herald added a reviewer: • jon. · View Herald TranscriptNov 30 2022, 11:44 AM

Herald added a subscriber: ashoat. · View Herald Transcript

marcin added a parent revision: D5775: Use new JSI call in SQLiteDataHandler.Nov 30 2022, 11:44 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 30 2022, 11:45 AM

Harbormaster failed remote builds in B13890: Diff 19030!

Looks like the keyserver failure is because of MariaDB release outage. I restarted it again (looks like you already restarted it once), but I think it's reasonable to "Request Review" with that workflow failing.

Harbormaster completed remote builds in B13890: Diff 19030.Nov 30 2022, 12:21 PM

marcin requested review of this revision.Nov 30 2022, 12:21 PM

tomek accepted this revision.Dec 1 2022, 6:23 AM

tomek added inline comments.

native/schema/CommCoreModuleSchema.js
33 ↗	(On Diff #19030)	Why do we keep sync versions?

This revision is now accepted and ready to land.Dec 1 2022, 6:23 AM

Rebase before landing

marcin added inline comments.Dec 2 2022, 12:47 AM

native/schema/CommCoreModuleSchema.js
33 ↗	(On Diff #19030)	Migration 32 in `native/redux/persist.js` uses `getAllMessagesSync`. `getAllThreadsSync` is not used anywhere but due to `getAllMessagesSync` usage I was afraid to remove it.