Page MenuHomePhabricator
Differential D5787

[services][blob] Use S3 abstraction in service
ClosedPublic
Actions

Authored by bartek on Dec 1 2022, 5:07 AM.
Tags
None
Referenced Files
F3249486: D5787.id19227.diff
Fri, Nov 15, 3:23 PM
Unknown Object (File)
Thu, Nov 7, 11:47 PM
Unknown Object (File)
Thu, Nov 7, 10:24 PM
Unknown Object (File)
Wed, Nov 6, 7:07 PM
Unknown Object (File)
Mon, Nov 4, 3:56 PM
Unknown Object (File)
Mon, Nov 4, 3:56 PM
Unknown Object (File)
Mon, Nov 4, 3:56 PM
Unknown Object (File)
Mon, Nov 4, 3:56 PM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
varun
• jon
tomek
Commits
rCOMM812f339aefe6: [services][blob] Use S3 abstraction in service
Summary

Follow up https://linear.app/comm/issue/ENG-2341/blob-service-create-s3-client-abstraction which follows up https://phab.comm.dev/D5682?id=18592#inline-38028

This diff replaces direct AWS S3 usages with the new S3Client abstraction. Also modified the MultiPartUploadSession not to be created directly, but only through S3Client.

Test Plan

Service builds. Blob service integration tests pass.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Dec 1 2022, 5:07 AM
bartek held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptDec 1 2022, 5:07 AM
bartek added a parent revision: D5786: [services][blob] Implement S3Client methods.Dec 1 2022, 5:14 AM
Harbormaster completed remote builds in B13914: Diff 19068.Dec 1 2022, 5:18 AM
bartek published this revision for review.Dec 1 2022, 6:04 AM
tomek accepted this revision.Dec 1 2022, 10:01 AM
• jon accepted this revision.Dec 6 2022, 4:15 PM

looks pretty standard to me

varun accepted this revision.Dec 6 2022, 8:04 PM
This revision is now accepted and ready to land.Dec 6 2022, 8:04 PM
bartek updated this revision to Diff 19205.Dec 7 2022, 4:46 AM

Updated the range value. Now it is clear if the range is inclusive or exclusive.

Harbormaster completed remote builds in B14030: Diff 19205.Dec 7 2022, 4:58 AM
Closed by commit rCOMM812f339aefe6: [services][blob] Use S3 abstraction in service (authored by bartek). · Explain WhyDec 7 2022, 10:37 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM812f339aefe6: [services][blob] Use S3 abstraction in service.

Revision Contents
Changeset List

PathSize
services/
blob/
src/
5 lines
3 lines
69 lines

Diff 19227

View Options

services/blob/src/main.rs

Loading...
View Options

services/blob/src/s3.rs

Loading...
View Options

services/blob/src/service.rs

Loading...