Details

Reviewers

ginsu
tomek
• derek
atul

Summary

refactored reducers to account for siweActionTypes, depends on D5634

Test Plan

coming soon

Diff Detail

Repository

rCOMM Comm

Branch

derek/login-types

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• derek created this revision.Dec 9 2022, 2:29 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 9 2022, 2:30 PM

Harbormaster failed remote builds in B14080: Diff 19276!

rebased

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 9 2022, 2:32 PM

Harbormaster failed remote builds in B14081: Diff 19278!

rebased

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 9 2022, 2:40 PM

Harbormaster failed remote builds in B14082: Diff 19279!

rebased onto stack

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 9 2022, 2:41 PM

Harbormaster failed remote builds in B14083: Diff 19280!

• derek added inline comments.Dec 9 2022, 2:42 PM

lib/actions/user-actions.js
98 ↗	(On Diff #19280)	no matter how i rebase this, i can't seem to get this endpoint to exist in the prior diff

rebased to master

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 9 2022, 2:44 PM

Harbormaster failed remote builds in B14084: Diff 19281!

rebased to include dependency on D5634

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 9 2022, 2:58 PM

Harbormaster failed remote builds in B14085: Diff 19282!

• derek edited the summary of this revision. (Show Details)Dec 9 2022, 2:58 PM

• derek added a parent revision: D5634: [keyserver] add public key/social proof to the cookie record.

• derek mentioned this in D5603: [keyserver/types] SIWE endpoint: types & native server call.Dec 9 2022, 3:01 PM

removed duplicate

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 9 2022, 3:29 PM

Harbormaster failed remote builds in B14086: Diff 19283!

atul commandeered this revision.Dec 22 2022, 12:07 AM

atul edited reviewers, added: • derek; removed: atul.

I assume we're abandoning this one as well given @atul's comment. We can always come back to it later if we change our mind

ashoat commandeered this revision.Dec 25 2022, 8:19 AM

ashoat abandoned this revision.

ashoat added a reviewer: atul.

[lib] SIWE: added types & modified reducers
AbandonedPublicDraft
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 19283

keyserver/src/creators/account-creator.js

lib/actions/user-actions.js

lib/reducers/calendar-filters-reducer.js

lib/reducers/connection-reducer.js

lib/reducers/data-loaded-reducer.js

lib/reducers/entry-reducer.js

lib/reducers/master-reducer.js

lib/reducers/message-reducer.js

lib/reducers/thread-reducer.js

lib/reducers/updates-reducer.js

lib/types/account-types.js

lib/types/entry-types.js

lib/utils/action-utils.js

[lib] SIWE: added types & modified reducersAbandonedPublicDraftActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 19283

keyserver/src/creators/account-creator.js

lib/actions/user-actions.js

lib/reducers/calendar-filters-reducer.js

lib/reducers/connection-reducer.js

lib/reducers/data-loaded-reducer.js

lib/reducers/entry-reducer.js

lib/reducers/master-reducer.js

lib/reducers/message-reducer.js

lib/reducers/thread-reducer.js

lib/reducers/updates-reducer.js

lib/types/account-types.js

lib/types/entry-types.js

lib/utils/action-utils.js

[lib] SIWE: added types & modified reducers
AbandonedPublicDraft
Actions

Revision Contents
Changeset List