Page MenuHomePhabricator

[lib] SIWE: added types & modified reducers
AbandonedPublicDraft

Authored by ashoat on Dec 9 2022, 2:29 PM.
Tags
None
Referenced Files
F3369154: D5851.diff
Mon, Nov 25, 10:04 PM
Unknown Object (File)
Fri, Nov 22, 4:31 PM
Unknown Object (File)
Fri, Nov 22, 4:08 PM
Unknown Object (File)
Sun, Nov 10, 5:59 PM
Unknown Object (File)
Sun, Nov 10, 5:55 PM
Unknown Object (File)
Wed, Nov 6, 5:14 PM
Unknown Object (File)
Mon, Nov 4, 4:04 PM
Unknown Object (File)
Mon, Nov 4, 4:04 PM

Details

Summary

refactored reducers to account for siweActionTypes, depends on D5634

Test Plan

coming soon

Diff Detail

Repository
rCOMM Comm
Branch
derek/login-types
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 9 2022, 2:30 PM
Harbormaster failed remote builds in B14080: Diff 19276!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 9 2022, 2:32 PM
Harbormaster failed remote builds in B14081: Diff 19278!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 9 2022, 2:40 PM
Harbormaster failed remote builds in B14082: Diff 19279!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 9 2022, 2:41 PM
Harbormaster failed remote builds in B14083: Diff 19280!
lib/actions/user-actions.js
98 ↗(On Diff #19280)

no matter how i rebase this, i can't seem to get this endpoint to exist in the prior diff

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 9 2022, 2:44 PM
Harbormaster failed remote builds in B14084: Diff 19281!

rebased to include dependency on D5634

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 9 2022, 2:58 PM
Harbormaster failed remote builds in B14085: Diff 19282!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 9 2022, 3:29 PM
Harbormaster failed remote builds in B14086: Diff 19283!
atul edited reviewers, added: derek; removed: atul.

I assume we're abandoning this one as well given @atul's comment. We can always come back to it later if we change our mind

ashoat abandoned this revision.
ashoat added a reviewer: atul.