Modal showing Terms of Use and Privacy Policy acknowledgment.
Design:
Example after server error
Details
Details
- Reviewers
tomek atul ashoat - Commits
- rCOMM654dbdeec554: [web] Terms of Use & Privacy modal
- I accept should update the value on keyserver DB
- User should not be able to close the modal using any method
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- policy-stuff-5
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/modals/terms-and-privacy-modal.css | ||
|---|---|---|
| 11 ↗ | (On Diff #19182) | We can use a shorthand but keeping as is also makes sense as it is more readable |
| 22 ↗ | (On Diff #19182) | We have a constant for this |
| web/modals/terms-and-privacy-modal.react.js | ||
| 38 ↗ | (On Diff #19182) | We have SetState<T> type and if we used that in acknowledgePolicy definition, we could simplify it here |
| 42–47 ↗ | (On Diff #19182) | It looks like the modal jumps a little bit after clicking the button. It might be caused by the difference in button size - you can check https://github.com/CommE2E/comm/blob/master/web/settings/relationship/add-users-list.react.js#L220-L227 which is an example of avoiding button size change. Maybe that will help. |
| 53 ↗ | (On Diff #19182) | We should use callback / a function defined outside the component |
Comment Actions
Looks great! Adding @ashoat because this diff adds new copy.
| web/modals/terms-and-privacy-modal.css | ||
|---|---|---|
| 1–5 | Maybe we should set a line height for the text. It feels like space between lines is a really small and doesn't match https://linear.app/comm/issue/ENG-2350#comment-5f0d2120 | |
Comment Actions
On second thought, I think we should revise the copy to:
We recently updated our Terms of Service & Privacy Policy. In order to continue using Comm, we're asking you to read through, acknowledge, and accept the updated policies.