Page MenuHomePhabricator
Differential D5821

[keyserver] add endpoint to acknowledge policy
ClosedPublic
Actions

Authored by kamil on Dec 6 2022, 5:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 20, 7:23 PM
Unknown Object (File)
Mon, Mar 17, 6:06 PM
Unknown Object (File)
Mon, Mar 17, 10:40 AM
Unknown Object (File)
Mon, Mar 17, 10:40 AM
Unknown Object (File)
Mon, Mar 17, 10:40 AM
Unknown Object (File)
Mon, Mar 17, 10:39 AM
Unknown Object (File)
Mon, Mar 17, 10:30 AM
Unknown Object (File)
Thu, Mar 13, 4:23 PM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
Commits
rCOMMe33199bde9f8: [keyserver] add endpoint to acknowledge policy
Summary

Endpoint which allows acknowledging policy, which is specified in request.

Preferring HTTP connection because in the future we maybe will want to close socket connection when policy is not accepted.

Context in ENG-2352

Test Plan
  1. hit endpoint with corrent and incorrect policy to check if validator works
  2. check if value is properly updated in policy_acknowledgments table

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Dec 6 2022, 5:51 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptDec 6 2022, 5:51 AM
kamil added a parent revision: D5820: Revert "[keyserver] update acknowledgment table in login was performed from proper source".Dec 6 2022, 5:52 AM
kamil edited the summary of this revision. (Show Details)
kamil edited the summary of this revision. (Show Details)Dec 6 2022, 5:55 AM
Harbormaster completed remote builds in B14001: Diff 19174.Dec 6 2022, 6:01 AM
kamil added a child revision: D5822: [keyserver] add viewer acknowledgment fetcher.Dec 6 2022, 6:03 AM
kamil published this revision for review.Dec 6 2022, 6:55 AM
tomek accepted this revision.Dec 6 2022, 9:16 AM
tomek added inline comments.
lib/types/endpoints.js
87 ↗(On Diff #19174)

It seems like we have sessionChangingEndpoints - if POLICY_ACKNOWLEDGMENT might change session, maybe we should put it there (depends on things like setting cookie, etc.). If we're expecting closing a socket we can also consider making it http only endpoint.

This revision is now accepted and ready to land.Dec 6 2022, 9:16 AM
kamil updated this revision to Diff 19310.Dec 13 2022, 4:41 AM

make policy_acknowledgment session changing endpoint

kamil added inline comments.Dec 13 2022, 4:43 AM
lib/types/endpoints.js
87 ↗(On Diff #19174)

Good point, added POLICY_ACKNOWLEDGMENT to sessionChangingEndpoints which made this also HTTPOnlyEndpoint

Harbormaster completed remote builds in B14110: Diff 19310.Dec 13 2022, 4:54 AM
Closed by commit rCOMMe33199bde9f8: [keyserver] add endpoint to acknowledge policy (authored by kamil). · Explain WhyDec 15 2022, 2:54 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMe33199bde9f8: [keyserver] add endpoint to acknowledge policy.

Revision Contents
Changeset List

PathSize
keyserver/
src/
2 lines
responders/
21 lines
lib/
types/
5 lines
1 line

Diff 19368

View Options

keyserver/src/endpoints.js

Show All 35 Linespub enum ReportType {
#[default] #[default]
ErrorReport = 0, ErrorReport = 0,
ThreadInconsistency = 1, ThreadInconsistency = 1,
EntryInconsistency = 2, EntryInconsistency = 2,
MediaMission = 3, MediaMission = 3,
UserInconsistency = 4, UserInconsistency = 4,
} }
impl ReportType {
pub fn is_error(&self) -> bool {
matches!(self, Self::ErrorReport)
}
pub fn is_media_mission(&self) -> bool {
matches!(self, Self::MediaMission)
}
pub fn is_inconsistency(&self) -> bool {
matches!(
self,
ReportType::ThreadInconsistency
| ReportType::EntryInconsistency
| ReportType::UserInconsistency
)
}
}
/// Report platform /// Report platform
#[derive(Clone, Debug, Serialize, Deserialize, Display)] #[derive(Clone, Debug, Serialize, Deserialize, Display)]
#[serde(rename_all = "lowercase")] #[serde(rename_all = "lowercase")]
pub enum ReportPlatform { pub enum ReportPlatform {
Android, Android,
IOS, IOS,
Web, Web,
Windows, Windows,
MacOS, MacOS,
} }
#[derive(Debug, Serialize, Deserialize)] #[derive(Debug, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")] #[serde(rename_all = "camelCase")]
pub struct PlatformDetails { pub struct PlatformDetails {
pub platform: ReportPlatform, pub platform: ReportPlatform,
code_version: Option<u16>, pub code_version: Option<u16>,
state_version: Option<u16>, pub state_version: Option<u16>,
} }
/// Input report payload - this is the JSON we receive from clients /// Input report payload - this is the JSON we receive from clients
#[derive(Debug, Deserialize)] #[derive(Debug, Deserialize)]
#[serde(rename_all = "camelCase")] #[serde(rename_all = "camelCase")]
#[serde(remote = "Self")] // we delegate to our custom validation trait #[serde(remote = "Self")] // we delegate to our custom validation trait
pub struct ReportInput { pub struct ReportInput {
pub platform_details: PlatformDetails, pub platform_details: PlatformDetails,
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines
View Options

keyserver/src/responders/user-responders.js

Show All 35 Linespub enum ReportType {
#[default] #[default]
ErrorReport = 0, ErrorReport = 0,
ThreadInconsistency = 1, ThreadInconsistency = 1,
EntryInconsistency = 2, EntryInconsistency = 2,
MediaMission = 3, MediaMission = 3,
UserInconsistency = 4, UserInconsistency = 4,
} }
impl ReportType {
pub fn is_error(&self) -> bool {
matches!(self, Self::ErrorReport)
}
pub fn is_media_mission(&self) -> bool {
matches!(self, Self::MediaMission)
}
pub fn is_inconsistency(&self) -> bool {
matches!(
self,
ReportType::ThreadInconsistency
| ReportType::EntryInconsistency
| ReportType::UserInconsistency
)
}
}
/// Report platform /// Report platform
#[derive(Clone, Debug, Serialize, Deserialize, Display)] #[derive(Clone, Debug, Serialize, Deserialize, Display)]
#[serde(rename_all = "lowercase")] #[serde(rename_all = "lowercase")]
pub enum ReportPlatform { pub enum ReportPlatform {
Android, Android,
IOS, IOS,
Web, Web,
Windows, Windows,
MacOS, MacOS,
} }
#[derive(Debug, Serialize, Deserialize)] #[derive(Debug, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")] #[serde(rename_all = "camelCase")]
pub struct PlatformDetails { pub struct PlatformDetails {
pub platform: ReportPlatform, pub platform: ReportPlatform,
code_version: Option<u16>, pub code_version: Option<u16>,
state_version: Option<u16>, pub state_version: Option<u16>,
} }
/// Input report payload - this is the JSON we receive from clients /// Input report payload - this is the JSON we receive from clients
#[derive(Debug, Deserialize)] #[derive(Debug, Deserialize)]
#[serde(rename_all = "camelCase")] #[serde(rename_all = "camelCase")]
#[serde(remote = "Self")] // we delegate to our custom validation trait #[serde(remote = "Self")] // we delegate to our custom validation trait
pub struct ReportInput { pub struct ReportInput {
pub platform_details: PlatformDetails, pub platform_details: PlatformDetails,
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines
View Options

lib/types/account-types.js

Show All 35 Linespub enum ReportType {
#[default] #[default]
ErrorReport = 0, ErrorReport = 0,
ThreadInconsistency = 1, ThreadInconsistency = 1,
EntryInconsistency = 2, EntryInconsistency = 2,
MediaMission = 3, MediaMission = 3,
UserInconsistency = 4, UserInconsistency = 4,
} }
impl ReportType {
pub fn is_error(&self) -> bool {
matches!(self, Self::ErrorReport)
}
pub fn is_media_mission(&self) -> bool {
matches!(self, Self::MediaMission)
}
pub fn is_inconsistency(&self) -> bool {
matches!(
self,
ReportType::ThreadInconsistency
| ReportType::EntryInconsistency
| ReportType::UserInconsistency
)
}
}
/// Report platform /// Report platform
#[derive(Clone, Debug, Serialize, Deserialize, Display)] #[derive(Clone, Debug, Serialize, Deserialize, Display)]
#[serde(rename_all = "lowercase")] #[serde(rename_all = "lowercase")]
pub enum ReportPlatform { pub enum ReportPlatform {
Android, Android,
IOS, IOS,
Web, Web,
Windows, Windows,
MacOS, MacOS,
} }
#[derive(Debug, Serialize, Deserialize)] #[derive(Debug, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")] #[serde(rename_all = "camelCase")]
pub struct PlatformDetails { pub struct PlatformDetails {
pub platform: ReportPlatform, pub platform: ReportPlatform,
code_version: Option<u16>, pub code_version: Option<u16>,
state_version: Option<u16>, pub state_version: Option<u16>,
} }
/// Input report payload - this is the JSON we receive from clients /// Input report payload - this is the JSON we receive from clients
#[derive(Debug, Deserialize)] #[derive(Debug, Deserialize)]
#[serde(rename_all = "camelCase")] #[serde(rename_all = "camelCase")]
#[serde(remote = "Self")] // we delegate to our custom validation trait #[serde(remote = "Self")] // we delegate to our custom validation trait
pub struct ReportInput { pub struct ReportInput {
pub platform_details: PlatformDetails, pub platform_details: PlatformDetails,
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines
View Options

lib/types/endpoints.js

Show All 35 Linespub enum ReportType {
#[default] #[default]
ErrorReport = 0, ErrorReport = 0,
ThreadInconsistency = 1, ThreadInconsistency = 1,
EntryInconsistency = 2, EntryInconsistency = 2,
MediaMission = 3, MediaMission = 3,
UserInconsistency = 4, UserInconsistency = 4,
} }
impl ReportType {
pub fn is_error(&self) -> bool {
matches!(self, Self::ErrorReport)
}
pub fn is_media_mission(&self) -> bool {
matches!(self, Self::MediaMission)
}
pub fn is_inconsistency(&self) -> bool {
matches!(
self,
ReportType::ThreadInconsistency
| ReportType::EntryInconsistency
| ReportType::UserInconsistency
)
}
}
/// Report platform /// Report platform
#[derive(Clone, Debug, Serialize, Deserialize, Display)] #[derive(Clone, Debug, Serialize, Deserialize, Display)]
#[serde(rename_all = "lowercase")] #[serde(rename_all = "lowercase")]
pub enum ReportPlatform { pub enum ReportPlatform {
Android, Android,
IOS, IOS,
Web, Web,
Windows, Windows,
MacOS, MacOS,
} }
#[derive(Debug, Serialize, Deserialize)] #[derive(Debug, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")] #[serde(rename_all = "camelCase")]
pub struct PlatformDetails { pub struct PlatformDetails {
pub platform: ReportPlatform, pub platform: ReportPlatform,
code_version: Option<u16>, pub code_version: Option<u16>,
state_version: Option<u16>, pub state_version: Option<u16>,
} }
/// Input report payload - this is the JSON we receive from clients /// Input report payload - this is the JSON we receive from clients
#[derive(Debug, Deserialize)] #[derive(Debug, Deserialize)]
#[serde(rename_all = "camelCase")] #[serde(rename_all = "camelCase")]
#[serde(remote = "Self")] // we delegate to our custom validation trait #[serde(remote = "Self")] // we delegate to our custom validation trait
pub struct ReportInput { pub struct ReportInput {
pub platform_details: PlatformDetails, pub platform_details: PlatformDetails,
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines