Endpoint which allows acknowledging policy, which is specified in request.
Preferring HTTP connection because in the future we maybe will want to close socket connection when policy is not accepted.
Context in ENG-2352
Details
Details
- Reviewers
tomek atul - Commits
- rCOMMe33199bde9f8: [keyserver] add endpoint to acknowledge policy
- hit endpoint with corrent and incorrect policy to check if validator works
- check if value is properly updated in policy_acknowledgments table
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/types/endpoints.js | ||
|---|---|---|
| 87 ↗ | (On Diff #19174) | It seems like we have sessionChangingEndpoints - if POLICY_ACKNOWLEDGMENT might change session, maybe we should put it there (depends on things like setting cookie, etc.). If we're expecting closing a socket we can also consider making it http only endpoint. |
| lib/types/endpoints.js | ||
|---|---|---|
| 87 ↗ | (On Diff #19174) | Good point, added POLICY_ACKNOWLEDGMENT to sessionChangingEndpoints which made this also HTTPOnlyEndpoint |