Page MenuHomePhabricator
Differential D5828

[lib] client function to call server and acknowledge policy
ClosedPublic
Actions

Authored by kamil on Dec 6 2022, 6:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 8:30 PM
Unknown Object (File)
Sun, Dec 15, 8:30 PM
Unknown Object (File)
Sun, Dec 15, 8:30 PM
Unknown Object (File)
Sun, Dec 15, 8:29 PM
Unknown Object (File)
Sun, Dec 15, 8:20 PM
Unknown Object (File)
Nov 8 2024, 9:59 AM
Unknown Object (File)
Nov 6 2024, 7:09 PM
Unknown Object (File)
Nov 6 2024, 7:09 PM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
Commits
rCOMMb7590f27a150: [lib] client function to call server and acknowledge policy
Summary

This function will be called when user will hit I accept and will send request to server with policy accepted by user.

Context in ENG-2363.

Test Plan

Call this function and check if proper action was dispatched and value on keyserver db was updated

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Dec 6 2022, 6:30 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptDec 6 2022, 6:30 AM
kamil edited the summary of this revision. (Show Details)Dec 6 2022, 6:31 AM
kamil added a parent revision: D5827: [lib] handle `policies_not_accepted` error on client.
kamil added a child revision: D5829: [web] Terms of Use & Privacy modal.Dec 6 2022, 6:38 AM
Harbormaster completed remote builds in B14008: Diff 19181.Dec 6 2022, 6:42 AM
kamil published this revision for review.Dec 6 2022, 6:56 AM
ashoat added a comment.Dec 6 2022, 7:01 PM

It's hard to review something when you just introduce a function without introducing its usage

tomek accepted this revision.Dec 9 2022, 10:06 AM
tomek added inline comments.
lib/utils/policy-acknowledge-utlis.js
30 ↗(On Diff #19181)

Why do we use startingPayload parameter?

This revision is now accepted and ready to land.Dec 9 2022, 10:06 AM
kamil mentioned this in D5826: [lib] client side logic for handling policy acknowledgment.Dec 13 2022, 5:45 AM
kamil updated this revision to Diff 19316.Dec 13 2022, 5:52 AM
kamil edited the summary of this revision. (Show Details)

remove startingPayload

kamil added a comment.Dec 13 2022, 5:58 AM
In D5828#174144, @ashoat wrote:

It's hard to review something when you just introduce a function without introducing its usage

I know but this function is used in diff where I'm introducing entire Terms of Use Modal so I wanted to make them separated to make it easier for the reviewer but will keep in mind your suggestion

lib/utils/policy-acknowledge-utlis.js
30 ↗(On Diff #19181)

It's not needed, thanks for catching

Harbormaster completed remote builds in B14116: Diff 19316.Dec 13 2022, 6:03 AM
kamil added a child revision: D5860: [web] refactor modal API to return modal key.Dec 13 2022, 6:55 AM
kamil removed a child revision: D5829: [web] Terms of Use & Privacy modal.
Closed by commit rCOMMb7590f27a150: [lib] client function to call server and acknowledge policy (authored by kamil). · Explain WhyDec 15 2022, 6:16 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMb7590f27a150: [lib] client function to call server and acknowledge policy.

Revision Contents
Changeset List

PathSize
lib/
utils/
32 lines

Diff 19385

View Options

lib/utils/policy-acknowledge-utlis.js

Loading...