Paths

Table of Contentst

-
lib/utils/
-
utils/
-
policy-acknowledge-utlis.js

[lib] client function to call server and acknowledge policy
ClosedPublic
Actions

Authored by kamil on Dec 6 2022, 6:30 AM.

Details

Reviewers

tomek
atul

Commits

rCOMMb7590f27a150: [lib] client function to call server and acknowledge policy

Summary

This function will be called when user will hit I accept and will send request to server with policy accepted by user.

Context in ENG-2363.

Test Plan

Call this function and check if proper action was dispatched and value on keyserver db was updated

Diff Detail

Repository

rCOMM Comm

Branch

policy-stuff-5

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Dec 6 2022, 6:30 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptDec 6 2022, 6:30 AM

kamil edited the summary of this revision. (Show Details)Dec 6 2022, 6:31 AM

kamil added a parent revision: D5827: [lib] handle `policies_not_accepted` error on client.

kamil added a child revision: D5829: [web] Terms of Use & Privacy modal.Dec 6 2022, 6:38 AM

Harbormaster completed remote builds in B14008: Diff 19181.Dec 6 2022, 6:42 AM

kamil published this revision for review.Dec 6 2022, 6:56 AM

It's hard to review something when you just introduce a function without introducing its usage

tomek accepted this revision.Dec 9 2022, 10:06 AM

tomek added inline comments.

lib/utils/policy-acknowledge-utlis.js
30 ↗	(On Diff #19181)	Why do we use `startingPayload` parameter?

This revision is now accepted and ready to land.Dec 9 2022, 10:06 AM

kamil mentioned this in D5826: [lib] client side logic for handling policy acknowledgment.Dec 13 2022, 5:45 AM

remove startingPayload

In D5828#174144, @ashoat wrote:

It's hard to review something when you just introduce a function without introducing its usage

I know but this function is used in diff where I'm introducing entire Terms of Use Modal so I wanted to make them separated to make it easier for the reviewer but will keep in mind your suggestion

lib/utils/policy-acknowledge-utlis.js
30 ↗	(On Diff #19181)	It's not needed, thanks for catching

Harbormaster completed remote builds in B14116: Diff 19316.Dec 13 2022, 6:03 AM

kamil added a child revision: D5860: [web] refactor modal API to return modal key.Dec 13 2022, 6:55 AM

kamil removed a child revision: D5829: [web] Terms of Use & Privacy modal.

Closed by commit rCOMMb7590f27a150: [lib] client function to call server and acknowledge policy (authored by kamil). · Explain WhyDec 15 2022, 6:16 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMb7590f27a150: [lib] client function to call server and acknowledge policy.

Revision Contents
Changeset List

Path

Size

lib/

utils/

policy-acknowledge-utlis.js

32 lines

Diff 19316

View Options

lib/utils/policy-acknowledge-utlis.js

Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Lines	type Props = {
+currentTabType: TabType,		+currentTabType: TabType,
+setCurrentTabType: SetState<TabType>,		+setCurrentTabType: SetState<TabType>,
+queuedChanges: ThreadChanges,		+queuedChanges: ThreadChanges,
+setQueuedChanges: SetState<ThreadChanges>,		+setQueuedChanges: SetState<ThreadChanges>,
+namePlaceholder: string,		+namePlaceholder: string,
+changeQueued: boolean,		+changeQueued: boolean,
+setTab: (tabType: TabType) => void,		+setTab: (tabType: TabType) => void,
+onChangeName: (event: SyntheticEvent<HTMLInputElement>) => void,		+onChangeName: (event: SyntheticEvent<HTMLInputElement>) => void,
		+onChangeDescription: (event: SyntheticEvent<HTMLTextAreaElement>) => void,
};		};
class ThreadSettingsModal extends React.PureComponent<Props> {		class ThreadSettingsModal extends React.PureComponent<Props> {
nameInput: ?HTMLInputElement;		nameInput: ?HTMLInputElement;
accountPasswordInput: ?HTMLInputElement;		accountPasswordInput: ?HTMLInputElement;

constructor(props: Props) {		constructor(props: Props) {
super(props);		super(props);
}		}
▲ Show 20 Lines • Show All 59 Lines • ▼ Show 20 Lines	if (this.props.currentTabType === 'general') {
mainContent = (		mainContent = (
<ThreadSettingsGeneralTab		<ThreadSettingsGeneralTab
threadNameValue={firstLine(this.possiblyChangedValue('name'))}		threadNameValue={firstLine(this.possiblyChangedValue('name'))}
threadNamePlaceholder={this.props.namePlaceholder}		threadNamePlaceholder={this.props.namePlaceholder}
threadNameOnChange={this.props.onChangeName}		threadNameOnChange={this.props.onChangeName}
threadNameDisabled={inputDisabled}		threadNameDisabled={inputDisabled}
threadNameInputRef={this.nameInputRef}		threadNameInputRef={this.nameInputRef}
threadDescriptionValue={this.possiblyChangedValue('description')}		threadDescriptionValue={this.possiblyChangedValue('description')}
threadDescriptionOnChange={this.onChangeDescription}		threadDescriptionOnChange={this.props.onChangeDescription}
threadDescriptionDisabled={inputDisabled}		threadDescriptionDisabled={inputDisabled}
threadColorCurrentColor={this.possiblyChangedValue('color')}		threadColorCurrentColor={this.possiblyChangedValue('color')}
threadColorOnColorSelection={this.onChangeColor}		threadColorOnColorSelection={this.onChangeColor}
/>		/>
);		);
} else if (this.props.currentTabType === 'privacy') {		} else if (this.props.currentTabType === 'privacy') {
mainContent = (		mainContent = (
<ThreadSettingsPrivacyTab		<ThreadSettingsPrivacyTab
▲ Show 20 Lines • Show All 102 Lines • ▼ Show 20 Lines	class ThreadSettingsModal extends React.PureComponent<Props> {
nameInputRef = (nameInput: ?HTMLInputElement) => {		nameInputRef = (nameInput: ?HTMLInputElement) => {
this.nameInput = nameInput;		this.nameInput = nameInput;
};		};

accountPasswordInputRef = (accountPasswordInput: ?HTMLInputElement) => {		accountPasswordInputRef = (accountPasswordInput: ?HTMLInputElement) => {
this.accountPasswordInput = accountPasswordInput;		this.accountPasswordInput = accountPasswordInput;
};		};

onChangeDescription = (event: SyntheticEvent<HTMLTextAreaElement>) => {
const target = event.currentTarget;
const newValue =
target.value !== this.props.threadInfo.description
? target.value
: undefined;
this.props.setQueuedChanges({
...this.props.queuedChanges,
description: newValue,
});
};

onChangeColor = (color: string) => {		onChangeColor = (color: string) => {
const newValue = color !== this.props.threadInfo.color ? color : undefined;		const newValue = color !== this.props.threadInfo.color ? color : undefined;
this.props.setQueuedChanges({		this.props.setQueuedChanges({
...this.props.queuedChanges,		...this.props.queuedChanges,
color: newValue,		color: newValue,
});		});
};		};

▲ Show 20 Lines • Show All 128 Lines • ▼ Show 20 Lines	const onChangeName = React.useCallback(
name: firstLine(		name: firstLine(
target.value !== threadInfo.name ? target.value : undefined,		target.value !== threadInfo.name ? target.value : undefined,
),		),
});		});
},		},
[queuedChanges, threadInfo],		[queuedChanges, threadInfo],
);		);

		const onChangeDescription = React.useCallback(
		(event: SyntheticEvent<HTMLTextAreaElement>) => {
		invariant(threadInfo, 'threadInfo should exist in onChangeDescription');
		const target = event.currentTarget;
		setQueuedChanges({
		...queuedChanges,
		description:
		target.value !== threadInfo.description ? target.value : undefined,
		});
		},
		[queuedChanges, threadInfo],
		);

if (!threadInfo) {		if (!threadInfo) {
return (		return (
<Modal onClose={modalContext.clearModal} name="Invalid thread">		<Modal onClose={modalContext.clearModal} name="Invalid thread">
<div className={css.modal_body}>		<div className={css.modal_body}>
<p>You no longer have permission to view this thread</p>		<p>You no longer have permission to view this thread</p>
</div>		</div>
</Modal>		</Modal>
);		);
Show All 17 Lines	return (
currentTabType={currentTabType}		currentTabType={currentTabType}
setCurrentTabType={setCurrentTabType}		setCurrentTabType={setCurrentTabType}
queuedChanges={queuedChanges}		queuedChanges={queuedChanges}
setQueuedChanges={setQueuedChanges}		setQueuedChanges={setQueuedChanges}
namePlaceholder={namePlaceholder}		namePlaceholder={namePlaceholder}
changeQueued={changeQueued}		changeQueued={changeQueued}
setTab={setTab}		setTab={setTab}
onChangeName={onChangeName}		onChangeName={onChangeName}
		onChangeDescription={onChangeDescription}
/>		/>
);		);
},		},
);		);

export default ConnectedThreadSettingsModal;		export default ConnectedThreadSettingsModal;

[lib] client function to call server and acknowledge policyClosedPublicActions