[lib] handle `policies_not_accepted` error on client
ClosedPublic
Actions

Authored by kamil on Dec 6 2022, 2:26 PM.

Details

Reviewers

tomek
atul

Commits

rCOMMfac4acc494a5: [lib] handle `policies_not_accepted` error on client

Summary

Catch policies_not_accepted ServerError on both HTTP request and WebSocket call and dispatch redux action which containing information that policies needs to be acknowledged

Context in ENG-2363.

Test Plan

Connect to keyserver from account without accepted policies and check if action was properly dispatched after interaction with keyserver on both mobile/web (testing both HTTP and WebSocket connection).

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Dec 6 2022, 2:26 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptDec 6 2022, 2:26 PM

kamil added a parent revision: D5826: [lib] client side logic for handling policy acknowledgment.Dec 6 2022, 2:27 PM

kamil added a child revision: D5828: [lib] client function to call server and acknowledge policy.Dec 6 2022, 2:31 PM

Harbormaster completed remote builds in B14007: Diff 19180.Dec 6 2022, 2:36 PM

kamil published this revision for review.Dec 6 2022, 2:56 PM

ashoat added inline comments.Dec 7 2022, 3:01 AM

lib/utils/call-server-endpoint.js
201–210 ↗	(On Diff #19180)	I think this would be cleaner if it was indented less

tomek accepted this revision.Dec 9 2022, 6:03 PM

tomek added inline comments.

lib/utils/call-server-endpoint.js
87–88 ↗	(On Diff #19180)	`options` is optional parameter, so maybe it makes more sense to keep it as the last one so that we can skip it when calling this function.
201–210 ↗	(On Diff #19180)	These aren't equivalent. In the solution from the diff we're throwing for each error and not just for all but `policies_not_accepted`. But still, there are other ways of reducing the indentation.