Catch policies_not_accepted ServerError on both HTTP request and WebSocket call and dispatch redux action which containing information that policies needs to be acknowledged
Context in ENG-2363.
Details
Details
Connect to keyserver from account without accepted policies and check if action was properly dispatched after interaction with keyserver on both mobile/web (testing both HTTP and WebSocket connection).
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/utils/call-server-endpoint.js | ||
|---|---|---|
| 201–210 ↗ | (On Diff #19180) | I think this would be cleaner if it was indented less |
| lib/utils/call-server-endpoint.js | ||
|---|---|---|
| 87–88 ↗ | (On Diff #19180) | options is optional parameter, so maybe it makes more sense to keep it as the last one so that we can skip it when calling this function. |
| 201–210 ↗ | (On Diff #19180) | These aren't equivalent. In the solution from the diff we're throwing for each error and not just for all but policies_not_accepted. But still, there are other ways of reducing the indentation. |
| lib/utils/call-server-endpoint.js | ||
|---|---|---|
| 201–210 ↗ | (On Diff #19180) | Ah, you're right, sorry for the confusion. It seems like I missed a return |