[lib] handle `policies_not_accepted` error on client
ClosedPublic
Actions

Authored by kamil on Dec 6 2022, 6:26 AM.

Details

Reviewers

tomek
atul

Commits

rCOMMfac4acc494a5: [lib] handle `policies_not_accepted` error on client

Summary

Catch policies_not_accepted ServerError on both HTTP request and WebSocket call and dispatch redux action which containing information that policies needs to be acknowledged

Context in ENG-2363.

Test Plan

Connect to keyserver from account without accepted policies and check if action was properly dispatched after interaction with keyserver on both mobile/web (testing both HTTP and WebSocket connection).

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Dec 6 2022, 6:26 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptDec 6 2022, 6:26 AM

kamil added a parent revision: D5826: [lib] client side logic for handling policy acknowledgment.Dec 6 2022, 6:27 AM

kamil added a child revision: D5828: [lib] client function to call server and acknowledge policy.Dec 6 2022, 6:31 AM

Harbormaster completed remote builds in B14007: Diff 19180.Dec 6 2022, 6:36 AM

kamil published this revision for review.Dec 6 2022, 6:56 AM

ashoat added inline comments.Dec 6 2022, 7:01 PM

lib/utils/call-server-endpoint.js
201–210	I think this would be cleaner if it was indented less

tomek accepted this revision.Dec 9 2022, 10:03 AM

tomek added inline comments.

lib/utils/call-server-endpoint.js
87–88	`options` is optional parameter, so maybe it makes more sense to keep it as the last one so that we can skip it when calling this function.
201–210	These aren't equivalent. In the solution from the diff we're throwing for each error and not just for all but `policies_not_accepted`. But still, there are other ways of reducing the indentation.