[native] Simplify `SIWEPanel` component
ClosedPublic
Actions

Authored by atul on Dec 19 2022, 1:56 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM08146dfd8c8a: [native] Simplify `SIWEPanel` component

Summary

There was a bunch of stuff in this component that seemed completely unnecessary. Just quickly stripped it out to simplify things since I'm modifying this file.

Test Plan

Clean build + clear caches
Able to hit SIWE button
Things open and continue to work as expected

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Dec 19 2022, 1:56 PM

atul published this revision for review.Dec 19 2022, 1:57 PM

atul added inline comments.

native/account/logged-out-modal.react.js
470–473	These props were unused.

add newline after @flow since we're here anyways

Harbormaster completed remote builds in B14475: Diff 19730.Dec 19 2022, 2:07 PM

re-arrange things a bit

Harbormaster completed remote builds in B14476: Diff 19731.Dec 19 2022, 2:09 PM

atul edited the summary of this revision. (Show Details)Dec 19 2022, 2:12 PM

Harbormaster completed remote builds in B14477: Diff 19732.Dec 19 2022, 2:20 PM

ashoat accepted this revision.Dec 19 2022, 2:23 PM

This revision is now accepted and ready to land.Dec 19 2022, 2:23 PM

Closed by commit rCOMM08146dfd8c8a: [native] Simplify `SIWEPanel` component (authored by atul). · Explain WhyDec 19 2022, 3:08 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM08146dfd8c8a: [native] Simplify `SIWEPanel` component.

Revision Contents
Changeset List

Path

Size

native/

account/

logged-out-modal.react.js

7 lines

siwe-panel.react.js

64 lines

Diff 19730

View Options

native/account/logged-out-modal.react.js