This button is shown only when the flag is set. When it is shown, the login buttons are replaced by restore.
https://linear.app/comm/issue/ENG-9678/introduce-a-restore-button
Depends on D13905
Restore enabled
Restore disabled
Differential D13906
[native] Introduce a restore button tomek on Tue, Nov 12, 6:10 AM. Authored by Tags None Referenced Files
Subscribers
Details This button is shown only when the flag is set. When it is shown, the login buttons are replaced by restore. https://linear.app/comm/issue/ENG-9678/introduce-a-restore-button Depends on D13905 Restore enabled Restore disabled Flow, tested that the correct set of buttons is shown depending on the flag.
Diff Detail
Event TimelineComment Actions I think it would be best to tuck the restore button behind the login button. Basically we would show the QR screen, and then there would be a link below it that says something like "No longer have access to your primary device?" What do you think? Comment Actions It sounds like you're proposing a solution where on the initial screen there are two buttons: Sign in and Register. Clicking Sign in opens the QR screen, where there is a No longer have access to your primary device? text. Clicking this link would open the restore screen. Is that correct? If yes, then it makes a lot of sense to me, because seeing a restore button on the initial screen might be confusing. This solution could be a little more complicated than the current one, because the QR screen is a modal that would modify the state of the logged out modal - but nothing too crazy. One suggestion I have is to consider whether the whole No longer have access to your primary device? text should be a link. Maybe we can keep it as plain text and introduce a restore button below it? Not sure how this button should look given the design of our QR screen. Comment Actions
Yes, exactly!
Hmm... the reason I'm thinking of a link is that our restore flow is comparable to a "Forgot password?" flow, and I usually see those accessed by a link. I think a button would be too distracting, and might come across as part of the QR code flow when it's really a separate thing. Would your concerns be addressed if we came up with shorter copy? Maybe "Lost your primary device?" Comment Actions
Yeah, that makes sense.
I was more concerned about users being able to notice that a link can be clickable. In the mobile app, we usually use buttons to indicate actions that can be performed. There are some usages of LinkButton, but only in the navigation header where users expect some actions to be possible. Comment Actions
That's a fair concern. It might be possible to improve with color, italics, underline, etc... might be easier to think about if we had a screenshot. Comment Actions To be honest, I think it looks okay without the underline. What do you think? I think it would be good to have the link aligned with the bottom of the "safe area" (just above the home pill). Separately: realizing from these screenshots that we tell the user to scan the QR code with their phone, not specifically their primary device. I suspect they maybe don't even know what a "primary device" is... Potentially, we could take the following approach:
Comment Actions
Agree, it is clear enough that this is a link
Updated on the screenshot
I'll create a separate diff for it
Created https://linear.app/comm/issue/ENG-9936/show-a-specific-error-when-scanning-a-qr-code-on-a-secondary-device to track Comment Actions Update the UI. Navigating from the QR screen to the restore flow will be added later in the stack. Comment Actions Looks great!
Comment Actions
Comment Actions
Ahh... yes of course, sorry that should've been obvious 😅 |