Page MenuHomePhabricator

[lib] Introduce a restore button
Needs ReviewPublic

Authored by tomek on Tue, Nov 12, 6:10 AM.
Tags
None
Referenced Files
F3234846: D13906.id45746.diff
Tue, Nov 12, 10:50 PM
F3234635: D13906.id.diff
Tue, Nov 12, 9:50 PM
F3234623: D13906.id.diff
Tue, Nov 12, 9:40 PM
Unknown Object (File)
Tue, Nov 12, 5:05 PM
Unknown Object (File)
Tue, Nov 12, 4:50 PM
Unknown Object (File)
Tue, Nov 12, 11:45 AM
Unknown Object (File)
Tue, Nov 12, 10:24 AM
Unknown Object (File)
Tue, Nov 12, 9:35 AM
Subscribers

Details

Summary

This button is shown only when the flag is set. When it is shown, the login buttons are replaced by restore.

https://linear.app/comm/issue/ENG-9678/introduce-a-restore-button

Depends on D13905

Restore enabled

prompt-true.png (2×1 px, 1 MB)

Restore disabled

prompt-false.png (2×1 px, 1 MB)

Test Plan

Flow, tested that the correct set of buttons is shown depending on the flag.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek edited the summary of this revision. (Show Details)
tomek edited the summary of this revision. (Show Details)
tomek requested review of this revision.Tue, Nov 12, 7:00 AM

I think it would be best to tuck the restore button behind the login button.

Basically we would show the QR screen, and then there would be a link below it that says something like "No longer have access to your primary device?"

What do you think?

I think it would be best to tuck the restore button behind the login button.

Basically we would show the QR screen, and then there would be a link below it that says something like "No longer have access to your primary device?"

What do you think?

It sounds like you're proposing a solution where on the initial screen there are two buttons: Sign in and Register. Clicking Sign in opens the QR screen, where there is a No longer have access to your primary device? text. Clicking this link would open the restore screen. Is that correct?

If yes, then it makes a lot of sense to me, because seeing a restore button on the initial screen might be confusing. This solution could be a little more complicated than the current one, because the QR screen is a modal that would modify the state of the logged out modal - but nothing too crazy.

One suggestion I have is to consider whether the whole No longer have access to your primary device? text should be a link. Maybe we can keep it as plain text and introduce a restore button below it? Not sure how this button should look given the design of our QR screen.

It sounds like you're proposing a solution where on the initial screen there are two buttons: Sign in and Register. Clicking Sign in opens the QR screen, where there is a No longer have access to your primary device? text. Clicking this link would open the restore screen. Is that correct?

Yes, exactly!

One suggestion I have is to consider whether the whole No longer have access to your primary device? text should be a link. Maybe we can keep it as plain text and introduce a restore button below it? Not sure how this button should look given the design of our QR screen.

Hmm... the reason I'm thinking of a link is that our restore flow is comparable to a "Forgot password?" flow, and I usually see those accessed by a link.

I think a button would be too distracting, and might come across as part of the QR code flow when it's really a separate thing.

Would your concerns be addressed if we came up with shorter copy? Maybe "Lost your primary device?"

Hmm... the reason I'm thinking of a link is that our restore flow is comparable to a "Forgot password?" flow, and I usually see those accessed by a link.

I think a button would be too distracting, and might come across as part of the QR code flow when it's really a separate thing.

Yeah, that makes sense.

Would your concerns be addressed if we came up with shorter copy? Maybe "Lost your primary device?"

I was more concerned about users being able to notice that a link can be clickable. In the mobile app, we usually use buttons to indicate actions that can be performed. There are some usages of LinkButton, but only in the navigation header where users expect some actions to be possible.

I was more concerned about users being able to notice that a link can be clickable. In the mobile app, we usually use buttons to indicate actions that can be performed. There are some usages of LinkButton, but only in the navigation header where users expect some actions to be possible.

That's a fair concern. It might be possible to improve with color, italics, underline, etc... might be easier to think about if we had a screenshot.