Page MenuHomePhabricator
Differential D14180

[native] Fall back to v1 login when the user doesn't have a backup
ClosedPublic
Actions

Authored by tomek on Dec 20 2024, 9:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 3, 3:40 AM
Unknown Object (File)
Wed, Apr 2, 9:04 PM
Unknown Object (File)
Wed, Apr 2, 11:42 AM
Unknown Object (File)
Tue, Apr 1, 8:01 AM
Unknown Object (File)
Thu, Mar 27, 4:27 AM
Unknown Object (File)
Mar 17 2025, 6:33 AM
Unknown Object (File)
Mar 15 2025, 3:54 PM
Unknown Object (File)
Mar 15 2025, 3:54 PM
View All 44 Files
Subscribers
ashoat

Details

Reviewers
kamil
bartek
Commits
rCOMM5b761cf201c9: [native] Fall back to v1 login when the user doesn't have a backup
Summary

Check if the user has a backup. When they don't have it, use the v1 login flow.

https://linear.app/comm/issue/ENG-9620/client-restore-flow-fall-back-to-v1-when-missing-backup

Depends on D14165

Test Plan

Because pf https://linear.app/comm/issue/ENG-10039/allow-checking-if-a-user-has-a-backup I had to hack it a bit: instead of calling retrieveLatestBackupInfo I hardcoded its return value to null. Then for both password and SIWE user verified that it is possible to log in.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Dec 20 2024, 9:04 AM
Herald added a subscriber: ashoat. · View Herald TranscriptDec 20 2024, 9:04 AM
Harbormaster completed remote builds in B33190: Diff 46594.Dec 20 2024, 9:22 AM
tomek requested review of this revision.Dec 20 2024, 9:22 AM
ashoat added inline comments.Dec 25 2024, 8:46 AM
native/account/restore-password-account-screen.react.js
52 ↗(On Diff #46594)

At some point we'll probably want to rename usePasswordLogIn (and associated hooks) to reflect that they are v1 / legacy

tomek added a child revision: D14182: [native] Update device list as a part of the restoration.Jan 7 2025, 1:21 AM
kamil accepted this revision.Jan 7 2025, 6:49 AM
kamil added 1 blocking reviewer(s): bartek.
kamil added inline comments.
native/account/restore-prompt-screen.react.js
57 ↗(On Diff #46594)

After skipping the regeneration of the social proof duringthe restore is done, this will have to change but for now looks good

bartek accepted this revision.Jan 7 2025, 7:20 AM

Because pf https://linear.app/comm/issue/ENG-10039/allow-checking-if-a-user-has-a-backup I had to hack it a bit: instead of calling retrieveLatestBackupInfo I hardcoded its return value to null. Then for both password and SIWE user verified that it is possible to log in.

I'm going to put up a diff which makes it behave as described in my inline comment

native/account/restore-password-account-screen.react.js
62–70 ↗(On Diff #46594)

Assuming retrieveLatestBackupInfo returns null only if user exists, but doesn't have backup, this code is okay.
If user with given username cannot be found by Backup Service, it should throw user_not_found which is caught below

This revision is now accepted and ready to land.Jan 7 2025, 7:20 AM
tomek added inline comments.Jan 8 2025, 9:21 AM
native/account/restore-password-account-screen.react.js
52 ↗(On Diff #46594)

Created https://linear.app/comm/issue/ENG-10074/rename-legacy-v1-functions-and-utils to track.

Closed by commit rCOMM5b761cf201c9: [native] Fall back to v1 login when the user doesn't have a backup (authored by tomek). · Explain WhyJan 8 2025, 9:30 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM5b761cf201c9: [native] Fall back to v1 login when the user doesn't have a backup.

Revision Contents
Changeset List

Diff 46611

View Options

native/account/restore-password-account-screen.react.js

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Linesforeach (ITEM ${DEV_SOURCE_CODE})
string(REPLACE ".dev.cpp" ".cpp" FILE_NAME ${FILE_FULL_NAME}) string(REPLACE ".dev.cpp" ".cpp" FILE_NAME ${FILE_FULL_NAME})
list(FILTER SOURCE_CODE EXCLUDE REGEX ".*${FILE_NAME}$") list(FILTER SOURCE_CODE EXCLUDE REGEX ".*${FILE_NAME}$")
list(APPEND SOURCE_CODE "${ITEM}") list(APPEND SOURCE_CODE "${ITEM}")
endforeach() endforeach()
include_directories( include_directories(
./src ./src
./src/DatabaseEntities ./src/DatabaseEntities
./src/Reactors/server
./src/Reactors/server/base-reactors
./_generated ./_generated
${FOLLY_INCLUDES} ${FOLLY_INCLUDES}
./lib/double-conversion ./lib/double-conversion
${Boost_INCLUDE_DIR} ${Boost_INCLUDE_DIR}
${DEV_HEADERS_PATH} ${DEV_HEADERS_PATH}
) )
# SERVER # SERVER
▲ Show 20 Lines • Show All 65 Lines • Show Last 20 Lines
View Options

native/account/restore-prompt-screen.react.js

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Linesforeach (ITEM ${DEV_SOURCE_CODE})
string(REPLACE ".dev.cpp" ".cpp" FILE_NAME ${FILE_FULL_NAME}) string(REPLACE ".dev.cpp" ".cpp" FILE_NAME ${FILE_FULL_NAME})
list(FILTER SOURCE_CODE EXCLUDE REGEX ".*${FILE_NAME}$") list(FILTER SOURCE_CODE EXCLUDE REGEX ".*${FILE_NAME}$")
list(APPEND SOURCE_CODE "${ITEM}") list(APPEND SOURCE_CODE "${ITEM}")
endforeach() endforeach()
include_directories( include_directories(
./src ./src
./src/DatabaseEntities ./src/DatabaseEntities
./src/Reactors/server
./src/Reactors/server/base-reactors
./_generated ./_generated
${FOLLY_INCLUDES} ${FOLLY_INCLUDES}
./lib/double-conversion ./lib/double-conversion
${Boost_INCLUDE_DIR} ${Boost_INCLUDE_DIR}
${DEV_HEADERS_PATH} ${DEV_HEADERS_PATH}
) )
# SERVER # SERVER
▲ Show 20 Lines • Show All 65 Lines • Show Last 20 Lines