Diff Detail
- Repository
- rCOMM Comm
- Branch
- restore
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/qr-code/qr-code-screen.react.js | ||
|---|---|---|
| 57 | I'm wondering if we should tell the user what a primary device is e.g. during the NUX. We could say something like "This is your primary device and you have to use it in order to log in on more devices". | |
| native/qr-code/qr-code-screen.react.js | ||
|---|---|---|
| 57 | Hmm... I wonder if this is too confusing to explain to most users, given most users only have a single phone. In D13906 I suggested either "logged-in phone" or "primary device", but now I'm wondering if "other phone" would be best. This would be extra confusing for users with 3 phones, but that has to be a tiny percentage of users... | |
| 96 | Can we add some paddingHorizontal here? I think it's a bit weird how close the text comes to the edge of the screen, and it doesn't look very good to have a second line with a single word (As an alternative to paddingHorizontal, we could consider setting an explicit width) | |