Show a panel where users can restore their account using SIWE.
https://linear.app/comm/issue/ENG-8203/implement-navigation-flow-for-new-siwe-log-in
Depends on D14084
Details
Details
Click the restore with SIWE button and check if the panel is shown correctly.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/account/restore-prompt-screen.react.js | ||
|---|---|---|
| 144 ↗ | (On Diff #46223) | We can also animate this value if we think the design direction is correct. I didn't want to introduce animations so that the rough idea could be discussed first, without too much investment. |
Comment Actions
Can you explain why you implemented this backdrop approach, instead of the approach we're using in ConnectEthereum?
Comment Actions
First of all, the Restore with Ethereum button doesn't have a loading state. Using the same approach that is used for the primary button while handling the loading state could be problematic, because of the white background. Also, while the backdrop is present, Restore with password button isn't interactive - which makes some sense, but on the other hand, we could give a user a way of stopping the SIWE panel from opening.
If we want to use a similar behavior to the ConnectEthereum, we would need to figure out how the loading state should look like. An alternative might be to use the same styling for the Ethereum button as we use for the password button.
Comment Actions
Tested how the alternative approach looks like:
I think it looks OK and we can keep it.
| native/account/prompt-button.react.js | ||
|---|---|---|
| 51 ↗ | (On Diff #46244) | After switching between button variants I realized that the SIWE button height is a little higher than the other variants. |