Page MenuHomePhabricator
Differential D14192

[native] Merge registration and sign in navigators
ClosedPublic
Actions

Authored by tomek on Jan 10 2025, 10:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 9, 8:57 PM
Unknown Object (File)
Sun, Mar 9, 8:57 PM
Unknown Object (File)
Sun, Mar 9, 8:57 PM
Unknown Object (File)
Sun, Mar 9, 8:57 PM
Unknown Object (File)
Feb 18 2025, 8:35 AM
Unknown Object (File)
Feb 18 2025, 8:35 AM
Unknown Object (File)
Feb 3 2025, 3:29 PM
Unknown Object (File)
Feb 3 2025, 3:29 PM
View All 48 Files
Subscribers
ashoat

Details

Reviewers
kamil
bartek
Commits
rCOMMf13d2dbc7e01: [native] Merge registration and sign in navigators
Summary

As a part of the registration flow we might need to open a screen from the restoration navigator and continue with the restoration flow. To make this interaction better, we need to have both flows in the same navigation structure.

https://linear.app/comm/issue/ENG-10040/handle-existing-wallet-registration

Depends on D14186

Test Plan

Check if it is possible to open both registration and restoration screens.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Jan 10 2025, 10:10 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJan 10 2025, 10:10 AM
tomek added inline comments.Jan 10 2025, 10:14 AM
native/account/logged-out-modal.react.js
402–406 ↗(On Diff #46641)

For some reason, Flow complains when navigation from the props is used (it tells that screen property isn't present). We're using useNavigation in some other places, so the simplest solution was to use this approach.

native/account/registration/registration-navigator.react.js
152 ↗(On Diff #46641)

All the related entities are renamed in the next diff because they are no longer registration-specific.

tomek added a child revision: D14193: [native] Rename registration navigator to auth navigator.Jan 10 2025, 10:15 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 10 2025, 10:24 AM
Harbormaster failed remote builds in B33219: Diff 46641!
tomek updated this revision to Diff 46645.Jan 10 2025, 10:28 AM

Fix the import

Harbormaster completed remote builds in B33223: Diff 46645.Jan 10 2025, 10:54 AM
tomek requested review of this revision.Jan 10 2025, 10:54 AM
kamil accepted this revision.Jan 13 2025, 2:39 AM
kamil added inline comments.
native/account/restore-password-account-screen.react.js
18 ↗(On Diff #46645)

nit

This revision is now accepted and ready to land.Jan 13 2025, 2:39 AM
tomek updated this revision to Diff 46653.Jan 13 2025, 3:14 AM

Fix imports

Harbormaster completed remote builds in B33229: Diff 46653.Jan 13 2025, 3:44 AM
Closed by commit rCOMMf13d2dbc7e01: [native] Merge registration and sign in navigators (authored by tomek). · Explain WhyJan 13 2025, 5:45 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMf13d2dbc7e01: [native] Merge registration and sign in navigators.

Revision Contents
Changeset List

Diff 46662

View Options

native/account/logged-out-modal.react.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

native/account/qr-code-screen.react.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

native/account/registration/registration-navigator.react.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

native/account/restore-backup-screen.react.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

native/account/restore-password-account-screen.react.js

Loading...
View Options

native/account/restore-prompt-screen.react.js

Loading...
View Options

native/account/sign-in-navigator.react.js

Loading...
View Options

native/navigation/root-navigator.react.js

Loading...
View Options

native/navigation/route-names.js

Loading...