Page MenuHomePhabricator
Differential D14183

[native] Read native credentials during restore flow
ClosedPublic
Actions

Authored by tomek on Jan 7 2025, 2:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 8:49 AM
Unknown Object (File)
Fri, Mar 14, 5:48 AM
Unknown Object (File)
Tue, Mar 11, 6:29 AM
Unknown Object (File)
Mon, Mar 10, 8:30 AM
Unknown Object (File)
Sun, Mar 9, 8:57 PM
Unknown Object (File)
Sun, Mar 9, 8:57 PM
Unknown Object (File)
Sun, Mar 9, 8:57 PM
Unknown Object (File)
Sun, Mar 9, 8:57 PM
View All 38 Files
Subscribers
ashoat

Details

Reviewers
kamil
bartek
Commits
rCOMMdeda5b62c6e7: [native] Read native credentials during restore flow
Summary

When a user restores their account, we should try to fill the input using native credentials - just like we do for the login flow.

https://linear.app/comm/issue/ENG-10046/use-native-credentials-on-the-password-restore-screen

Depends on D14182

Test Plan

Register a password account, wipe state, open restore password screen - the input should contain credentials of the registered account.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 46613

View Options

native/account/native-credentials.js

Show All 30 Lines
use super::DatabaseClient; use super::DatabaseClient;
impl DatabaseClient { impl DatabaseClient {
/// Gets the next one-time key for the account and then, in a transaction, /// Gets the next one-time key for the account and then, in a transaction,
/// deletes the key and updates the key count /// deletes the key and updates the key count
/// ///
/// Returns the retrieved one-time key if it exists and a boolean indicating /// Returns the retrieved one-time key if it exists and a boolean indicating
/// whether the `spawn_refresh_keys_task`` was called /// whether the `spawn_refresh_keys_task`` was called
#[tracing::instrument(skip_all)]
pub(super) async fn get_one_time_key( pub(super) async fn get_one_time_key(
&self, &self,
user_id: &str, user_id: &str,
device_id: &str, device_id: &str,
account_type: OlmAccountType, account_type: OlmAccountType,
can_request_more_keys: bool, can_request_more_keys: bool,
) -> Result<(Option<String>, bool), Error> { ) -> Result<(Option<String>, bool), Error> {
use crate::constants::devices_table; use crate::constants::devices_table;
▲ Show 20 Lines • Show All 102 Lines • ▼ Show 20 Lines loop {
); );
return Err(Error::AwsSdk(dynamo_db_error)); return Err(Error::AwsSdk(dynamo_db_error));
} }
} }
} }
} }
} }
#[tracing::instrument(skip_all)]
async fn get_one_time_keys( async fn get_one_time_keys(
&self, &self,
user_id: &str, user_id: &str,
device_id: &str, device_id: &str,
account_type: OlmAccountType, account_type: OlmAccountType,
num_keys: Option<usize>, num_keys: Option<usize>,
) -> Result<Vec<OTKRow>, Error> { ) -> Result<Vec<OTKRow>, Error> {
use crate::constants::one_time_keys_table::*; use crate::constants::one_time_keys_table::*;
Show All 33 Lines if let Some(limit) = num_keys {
error!("There are fewer one-time keys than the number requested"); error!("There are fewer one-time keys than the number requested");
return Err(Error::NotEnoughOneTimeKeys); return Err(Error::NotEnoughOneTimeKeys);
} }
} }
Ok(otk_rows) Ok(otk_rows)
} }
#[tracing::instrument(skip_all)]
pub async fn append_one_time_prekeys( pub async fn append_one_time_prekeys(
&self, &self,
user_id: &str, user_id: &str,
device_id: &str, device_id: &str,
content_one_time_keys: &Vec<String>, content_one_time_keys: &Vec<String>,
notif_one_time_keys: &Vec<String>, notif_one_time_keys: &Vec<String>,
) -> Result<(), Error> { ) -> Result<(), Error> {
use crate::constants::retry; use crate::constants::retry;
▲ Show 20 Lines • Show All 115 Lines • ▼ Show 20 Lines loop {
} }
} }
} }
} }
Ok(()) Ok(())
} }
#[tracing::instrument(skip_all)]
async fn get_otk_count( async fn get_otk_count(
&self, &self,
user_id: &str, user_id: &str,
device_id: &str, device_id: &str,
account_type: OlmAccountType, account_type: OlmAccountType,
) -> Result<usize, Error> { ) -> Result<usize, Error> {
use crate::constants::devices_table; use crate::constants::devices_table;
▲ Show 20 Lines • Show All 142 Lines • Show Last 20 Lines
View Options

native/account/restore-password-account-screen.react.js

Show All 30 Lines
use super::DatabaseClient; use super::DatabaseClient;
impl DatabaseClient { impl DatabaseClient {
/// Gets the next one-time key for the account and then, in a transaction, /// Gets the next one-time key for the account and then, in a transaction,
/// deletes the key and updates the key count /// deletes the key and updates the key count
/// ///
/// Returns the retrieved one-time key if it exists and a boolean indicating /// Returns the retrieved one-time key if it exists and a boolean indicating
/// whether the `spawn_refresh_keys_task`` was called /// whether the `spawn_refresh_keys_task`` was called
#[tracing::instrument(skip_all)]
pub(super) async fn get_one_time_key( pub(super) async fn get_one_time_key(
&self, &self,
user_id: &str, user_id: &str,
device_id: &str, device_id: &str,
account_type: OlmAccountType, account_type: OlmAccountType,
can_request_more_keys: bool, can_request_more_keys: bool,
) -> Result<(Option<String>, bool), Error> { ) -> Result<(Option<String>, bool), Error> {
use crate::constants::devices_table; use crate::constants::devices_table;
▲ Show 20 Lines • Show All 102 Lines • ▼ Show 20 Lines loop {
); );
return Err(Error::AwsSdk(dynamo_db_error)); return Err(Error::AwsSdk(dynamo_db_error));
} }
} }
} }
} }
} }
#[tracing::instrument(skip_all)]
async fn get_one_time_keys( async fn get_one_time_keys(
&self, &self,
user_id: &str, user_id: &str,
device_id: &str, device_id: &str,
account_type: OlmAccountType, account_type: OlmAccountType,
num_keys: Option<usize>, num_keys: Option<usize>,
) -> Result<Vec<OTKRow>, Error> { ) -> Result<Vec<OTKRow>, Error> {
use crate::constants::one_time_keys_table::*; use crate::constants::one_time_keys_table::*;
Show All 33 Lines if let Some(limit) = num_keys {
error!("There are fewer one-time keys than the number requested"); error!("There are fewer one-time keys than the number requested");
return Err(Error::NotEnoughOneTimeKeys); return Err(Error::NotEnoughOneTimeKeys);
} }
} }
Ok(otk_rows) Ok(otk_rows)
} }
#[tracing::instrument(skip_all)]
pub async fn append_one_time_prekeys( pub async fn append_one_time_prekeys(
&self, &self,
user_id: &str, user_id: &str,
device_id: &str, device_id: &str,
content_one_time_keys: &Vec<String>, content_one_time_keys: &Vec<String>,
notif_one_time_keys: &Vec<String>, notif_one_time_keys: &Vec<String>,
) -> Result<(), Error> { ) -> Result<(), Error> {
use crate::constants::retry; use crate::constants::retry;
▲ Show 20 Lines • Show All 115 Lines • ▼ Show 20 Lines loop {
} }
} }
} }
} }
Ok(()) Ok(())
} }
#[tracing::instrument(skip_all)]
async fn get_otk_count( async fn get_otk_count(
&self, &self,
user_id: &str, user_id: &str,
device_id: &str, device_id: &str,
account_type: OlmAccountType, account_type: OlmAccountType,
) -> Result<usize, Error> { ) -> Result<usize, Error> {
use crate::constants::devices_table; use crate::constants::devices_table;
▲ Show 20 Lines • Show All 142 Lines • Show Last 20 Lines