Details

Reviewers

• jon
bartek

Commits

rCOMMdefc668d683c: [services/commtest] Tunnelbroker - Adding the API integration tests call…

Summary

This diff introduces an integrational tests call for the Tunnelbroker API:

We are checking for the wrong formatted deviceID: the server should return an error.
Generating a keypair for making a signature.
Getting a string to be signed from the Tunnelbroker server for the deviceID.
Checking for the server error in case the provided signature is wrong.
Create a new session (getting sessionID) by calling the Tunnelbroker new session API call.

Linear task: ENG-1657

Test Plan

The commtest app is successfully built.
To run tests:
- Start the Tunnelbroker server using the nix develop --accept-flake-config -c bash -c "cargo run" command in the services/tunnelbroker directory.
- Open another terminal and run the following command from the services/commtest directory:

nix develop --accept-flake-config -c bash -c "cargo t --test tunnelbroker_integration_test -- --nocapture"

The expected result is that the commapp will be running the tests for the Tunnelbroker API.

Diff Detail

Repository

rCOMM Comm

Branch

commtest-new-session-tests

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Dec 19 2022, 6:52 AM

• max held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptDec 19 2022, 6:52 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald Transcript

• max added a parent revision: D5929: [services/commtest] Tunnelbroker - Adding `deviceID` validation check function.Dec 19 2022, 6:52 AM

• max mentioned this in D5926: [services/commtest] Adding of openssl, base64, anyhow to dependencies.Dec 19 2022, 7:00 AM

Harbormaster completed remote builds in B14315: Diff 19557.Dec 19 2022, 7:03 AM

• max mentioned this in D5837: [services/commtest] Tunnelbroker - Adding of helper function for the `SessionSignature` client request.Dec 19 2022, 7:03 AM

• max mentioned this in D5927: [services/commtest] Tunnelbroker - Adding of helper function for the string signing with the private key.Dec 19 2022, 7:07 AM

• max mentioned this in D5838: [services/commtest] Tunnelbroker - Adding of helper function for the `NewSession` client request.

• max mentioned this in D5928: [services/commtest] Tunnelbroker - Adding the tonic client builder function.Dec 19 2022, 7:12 AM

• max mentioned this in D5929: [services/commtest] Tunnelbroker - Adding `deviceID` validation check function.Dec 19 2022, 7:17 AM

• max published this revision for review.Dec 19 2022, 7:26 AM

• max edited the summary of this revision. (Show Details)

• max edited the test plan for this revision. (Show Details)

• max added a reviewer: bartek. • max added 1 blocking reviewer(s): • jon.

Rebasing on parent changes, removing unwrap() in a favor of anyhow.

Harbormaster completed remote builds in B14526: Diff 19783.Dec 20 2022, 9:39 AM

was unable to do arc patch without a conflict, but overall looks good to me

services/commtest/tests/tunnelbroker_integration_test.rs
5	not super related to this task, but I think the namespace would be a bit cleaner as `commtest::tunnelbroker::utils`. As `tunnelbroker_utils` is a bit redundant.

This revision is now accepted and ready to land.Dec 20 2022, 10:00 AM

• max mentioned this in D5944: [services] Tunnelbroker - Adding of the `base64` crate to dependencies.Dec 21 2022, 5:41 AM

• max mentioned this in D5945: [services] Tunnelbroker - Adding signed string verification function.Dec 21 2022, 5:45 AM

• max mentioned this in D5946: [services] Tunnelbroker - Expose string to be signed to the Rust.Dec 21 2022, 5:51 AM

• max mentioned this in D5947: [services] Tunnelbroker - Modify server handler to use Rust signature verification.Dec 21 2022, 5:57 AM

bartek accepted this revision.Dec 21 2022, 11:16 PM

• max mentioned this in rCOMM8ab6a820b421: [services/commtest] Adding of openssl, base64, anyhow to dependencies.Dec 27 2022, 4:52 AM

Rebasing on master.

• max marked an inline comment as done.Dec 27 2022, 5:24 AM

• max added inline comments.

services/commtest/tests/tunnelbroker_integration_test.rs
5	not super related to this task, but I think the namespace would be a bit cleaner as `commtest::tunnelbroker::utils`. As `tunnelbroker_utils` is a bit redundant. I'm following the current code convention that we have in a `commtest`. We have the same for the blob and backup.