Paths

Table of Contentst

Differential D5946

[services] Tunnelbroker - Expose string to be signed to the Rust
ClosedPublic
Actions

Authored by • max on Dec 19 2022, 12:36 PM.

Tags

None

Referenced Files

	F2105073: D5946.id.diff
	Tue, Jun 25, 6:26 AM

	Unknown Object (File)
	Mon, Jun 24, 3:52 AM

	Unknown Object (File)
	Sun, Jun 23, 11:54 PM

	Unknown Object (File)
	Sat, Jun 22, 8:53 PM

	Unknown Object (File)
	Sat, Jun 22, 1:03 PM

	Unknown Object (File)
	Fri, Jun 14, 10:00 PM

	Unknown Object (File)
	Fri, Jun 14, 4:36 PM

	Unknown Object (File)
	Thu, Jun 13, 11:34 PM

Subscribers

Details

Reviewers

• jon
bartek
tomek

Commits

rCOMM2a6ad8ddbc0d: [services] Tunnelbroker - Expose string to be signed to the Rust

Summary

This diff introduces adding of the getStringToSign C++ function which is exposed to the Rust using the CXX bridge to get the string to verify from the DynamoDB database by the deviceID.
To create a new session client first gets the verification string from the server and then sign it with the private key. The randomly generated string is saved into the DynamoDB table for the corresponding deviceID during the request. To verify the string in the following D5947 and Rust verify function in D5945 we should get this string.

Linear task: ENG-2492

Test Plan

As this diff is a part of the stack this diff can be tested on the end of the stack at D5947.
To test it:

Patch to the D5947
Run the integration tests in D5931 using the cargo t --test tunnelbroker_integration_test command.

The expected result is passing the integration test (signing and verifying the string are successful and the new session creation test will pass).

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.Dec 19 2022, 12:36 PM

• max held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptDec 19 2022, 12:36 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald Transcript

• max added a parent revision: D5945: [services] Tunnelbroker - Adding signed string verification function.Dec 19 2022, 12:36 PM

• max added a child revision: D5947: [services] Tunnelbroker - Modify server handler to use Rust signature verification.

Harbormaster failed remote builds in B14467: Diff 19722!Dec 19 2022, 1:03 PM

Adding of the empty result from the database check.

Harbormaster failed remote builds in B14527: Diff 19784!Dec 20 2022, 9:37 AM

• max edited the summary of this revision. (Show Details)Dec 21 2022, 5:51 AM

• max edited the test plan for this revision. (Show Details)

• max added a reviewer: bartek. • max added 1 blocking reviewer(s): • jon.

• max edited the summary of this revision. (Show Details)

As we have trouble using Nix in the CI gate please ignore the Nix build fail for now.

going to rubber stamp this,

CI should get fixed if you rebase on master

would like for @tomek to take a look as well. (My c++ isn't great)

This revision is now accepted and ready to land.Dec 21 2022, 2:02 PM

• jon added a reviewer: tomek.Dec 21 2022, 2:02 PM

This revision now requires review to proceed.Dec 21 2022, 2:02 PM

Looks good to me

tomek accepted this revision.Dec 22 2022, 7:07 AM

This revision is now accepted and ready to land.Dec 22 2022, 7:07 AM

Changing the function name from getStringToSign to getSavedNonceToSign which will be more self describing and based on the D5947#181356 comment.

Harbormaster failed remote builds in B14800: Diff 20185!Dec 27 2022, 7:22 AM

Harbormaster completed remote builds in B14800: Diff 20185.Dec 27 2022, 7:29 AM

• max mentioned this in D5947: [services] Tunnelbroker - Modify server handler to use Rust signature verification.Dec 28 2022, 6:27 AM

Fix merging, rebasing on master.

Harbormaster completed remote builds in B14839: Diff 20235.Dec 28 2022, 8:08 AM

Closed by commit rCOMM2a6ad8ddbc0d: [services] Tunnelbroker - Expose string to be signed to the Rust (authored by • max). · Explain WhyDec 28 2022, 8:14 AM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMM2a6ad8ddbc0d: [services] Tunnelbroker - Expose string to be signed to the Rust.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

1 line

libcpp/

1 line

Tunnelbroker.cpp

11 lines

Diff 20238

services/tunnelbroker/src/cxx_bridge.rs

Loading...

services/tunnelbroker/src/libcpp/Tunnelbroker.h

Loading...

services/tunnelbroker/src/libcpp/Tunnelbroker.cpp

Loading...