Page MenuHomePhabricator
Differential D5949

[services] Tunnelbroker - Remove `cryptopp` from dependencies
ClosedPublic
Actions

Authored by • max on Dec 19 2022, 12:38 PM.
Tags
None
Referenced Files
F3491067: D5949.id20253.diff
Wed, Dec 18, 6:16 PM
F3491066: D5949.id20249.diff
Wed, Dec 18, 6:16 PM
F3491065: D5949.id20065.diff
Wed, Dec 18, 6:16 PM
F3491064: D5949.id19754.diff
Wed, Dec 18, 6:16 PM
F3491063: D5949.id19725.diff
Wed, Dec 18, 6:16 PM
F3488670: D5949.id.diff
Wed, Dec 18, 10:59 AM
Unknown Object (File)
Sat, Nov 23, 12:01 PM
Unknown Object (File)
Nov 6 2024, 6:28 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• jon
bartek
varun
ashoat
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rCOMM578d3d993813: [services] Tunnelbroker - Remove `cryptopp` from dependencies
Summary

This diff removes the deprecated C++ cryptopp library from the dependencies.
In D5947 we are switched to using the Rust function for the signed string verification and we don't need the cryptopp and related C++ code base anymore.

Linear task: ENG-2492

Test Plan

Passing CI gates.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.Dec 19 2022, 12:38 PM
• max held this revision as a draft.
Owners added a reviewer: Restricted Owners Package.Dec 19 2022, 12:38 PM
Herald added a reviewer: • jon. · View Herald TranscriptDec 19 2022, 12:38 PM
Herald added a reviewer: • jon. · View Herald Transcript
Herald added subscribers: atul, tomek, ashoat. · View Herald Transcript
• max added a parent revision: D5948: [services] Tunnelbroker - Remove `cryptopp` usage from the C++ codebase.Dec 19 2022, 12:39 PM
Harbormaster failed remote builds in B14470: Diff 19725!Dec 19 2022, 1:07 PM
• max updated this revision to Diff 19754.Dec 20 2022, 4:37 AM

Rebasing on master changes.

Harbormaster failed remote builds in B14497: Diff 19754!Dec 20 2022, 4:37 AM
• max mentioned this in D5948: [services] Tunnelbroker - Remove `cryptopp` usage from the C++ codebase.Dec 21 2022, 6:01 AM
• max edited the summary of this revision. (Show Details)
• max edited the test plan for this revision. (Show Details)
• max added a reviewer: bartek.
• max published this revision for review.Dec 21 2022, 6:07 AM

As we have trouble using Nix in the CI gate please ignore the Nix build fail for now.

varun accepted this revision.Dec 21 2022, 1:36 PM
This revision is now accepted and ready to land.Dec 21 2022, 1:36 PM
• max updated this revision to Diff 20065.Dec 23 2022, 7:47 AM

Rebasing on master changes.

Harbormaster completed remote builds in B14712: Diff 20065.Dec 23 2022, 8:01 AM
• max added a reviewer: ashoat.Dec 23 2022, 8:07 AM
This revision now requires review to proceed.Dec 23 2022, 8:07 AM
• max added a comment.Dec 23 2022, 8:08 AM

Adding @ashoat for a final pass because this diff touches dependencies.

ashoat accepted this revision.Dec 23 2022, 10:24 AM
This revision is now accepted and ready to land.Dec 23 2022, 10:24 AM
• max mentioned this in rCOMM506641f4a271: [services] Tunnelbroker - Remove `cryptopp` usage from the C++ codebase.Dec 28 2022, 10:30 AM
• max updated this revision to Diff 20249.Dec 28 2022, 10:31 AM

Merging with master changes.

Harbormaster completed remote builds in B14848: Diff 20249.Dec 28 2022, 10:43 AM
Closed by commit rCOMM578d3d993813: [services] Tunnelbroker - Remove `cryptopp` from dependencies (authored by • max). · Explain WhyDec 28 2022, 10:43 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM578d3d993813: [services] Tunnelbroker - Remove `cryptopp` from dependencies.

Revision Contents
Changeset List

PathSize
nix/
2 lines
services/
tunnelbroker/
1 line
1 line
docker/
src/
libcpp/
test/
8 lines

Diff 20253

View Options

nix/dev-shell.nix

Loading...
View Options

services/tunnelbroker/Dockerfile

Loading...
View Options

services/tunnelbroker/build.rs

Loading...
View Options

services/tunnelbroker/docker/install_cryptopp.sh

Loading...
View Options

services/tunnelbroker/src/libcpp/test/CMakeLists.txt

Loading...