Page MenuHomePhabricator

[services] Tunnelbroker - Adding of the `base64` crate to dependencies
ClosedPublic

Authored by max on Dec 19 2022, 12:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 6:16 PM
Unknown Object (File)
Wed, Dec 18, 6:16 PM
Unknown Object (File)
Wed, Dec 18, 6:16 PM
Unknown Object (File)
Wed, Dec 18, 6:16 PM
Unknown Object (File)
Wed, Dec 18, 6:16 PM
Unknown Object (File)
Wed, Dec 18, 6:16 PM
Unknown Object (File)
Wed, Dec 18, 10:59 AM
Unknown Object (File)
Sun, Nov 24, 2:40 PM
Subscribers

Details

Summary

This diff adds a base64 crate to the Cargo Tunnelbroker dependencies.
base64 functions will be used in the following D5945 in a verify_signed_string function.

Linear task: ENG-2492

Test Plan

As this diff is a part of the stack this diff can be tested on the end of the stack at D5947.
To test it:

  • Patch to the D5947
  • Run the integration tests in D5931 using the cargo t --test tunnelbroker_integration_test command.

The expected result is passing the integration test (signing and verifying the string are successful and the new session creation test will pass).

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

max held this revision as a draft.

Rebasing on master changes.

Rebasing on a master changes.

max edited the test plan for this revision. (Show Details)
max added a reviewer: bartek. max added 1 blocking reviewer(s): jon.
max published this revision for review.Dec 21 2022, 6:05 AM

As we have trouble using Nix in the CI gate please ignore the Nix build fail for now.

Gate should be fixed if you rebase on master

This revision is now accepted and ready to land.Dec 21 2022, 2:00 PM
This revision now requires review to proceed.Dec 23 2022, 8:06 AM

Adding @ashoat for a final pass because this diff touches dependencies.

This revision is now accepted and ready to land.Dec 23 2022, 10:24 AM