Page MenuHomePhabricator
Differential D5996

[native/iOS] initialize database on app start
ClosedPublic
Actions

Authored by kamil on Dec 22 2022, 2:57 AM.
Tags
None
Referenced Files
F3499106: D5996.id21585.diff
Thu, Dec 19, 10:34 PM
Unknown Object (File)
Thu, Dec 19, 7:16 PM
Unknown Object (File)
Wed, Dec 18, 11:02 PM
Unknown Object (File)
Wed, Dec 18, 5:19 PM
Unknown Object (File)
Sat, Dec 14, 4:44 PM
Unknown Object (File)
Sat, Dec 14, 8:11 AM
Unknown Object (File)
Sat, Dec 14, 8:11 AM
Unknown Object (File)
Sat, Dec 14, 8:11 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
marcin
tomek
Commits
rCOMM4e11a2611ec4: [native/iOS] initialize database on app start
Summary

This code will initialize db on iOS.
Context in ENG-2071

Test Plan

Tested on simulator and iOS.

  1. Created malformed db (e.g. simulate bug described in ENG-1910)
  2. Open the app - should be terminated
  3. Open again - app should delete database and perform soft-logout and continue running with proper structure

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Dec 22 2022, 2:57 AM
kamil held this revision as a draft.
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 22 2022, 2:57 AM
Harbormaster completed remote builds in B14680: Diff 20019.Dec 22 2022, 3:11 AM
kamil added a parent revision: D5995: [native] clear database when malformation is detected.Dec 22 2022, 3:27 AM
kamil published this revision for review.Dec 22 2022, 3:32 AM
marcin added inline comments.Dec 26 2022, 2:41 AM
native/ios/Comm/AppDelegate.mm
204

Why do we want to catch here? As of my experience try - catch in this particular place might not be useful. Application is backgrounded, sot even if the app crashes user is not that directly affected. Additionally, we loos opportunity to receive meaningful crash log and we let application continue to work with possible persisting error in the database.

kamil updated this revision to Diff 20433.Dec 30 2022, 5:06 AM

remove try {} catch() {} for background notifs

native/ios/Comm/AppDelegate.mm
204

Good point with that, removing this

Harbormaster completed remote builds in B14973: Diff 20433.Dec 30 2022, 5:20 AM
marcin accepted this revision.Jan 2 2023, 4:04 AM
marcin added a reviewer: tomek.
tomek accepted this revision.Jan 2 2023, 4:34 AM
tomek added inline comments.
native/ios/Comm/AppDelegate.mm
72–73 ↗(On Diff #20433)

Can we put this into attemptDatabaseInitialization?

This revision is now accepted and ready to land.Jan 2 2023, 4:34 AM
kamil added a child revision: D6210: [native/Android] initialize database on app start.Jan 10 2023, 7:26 AM
kamil updated this revision to Diff 21585.Jan 30 2023, 4:10 AM

move call into attemptDatabaseInitialization and test notifs

Harbormaster completed remote builds in B15839: Diff 21585.Jan 30 2023, 4:23 AM
Closed by commit rCOMM4e11a2611ec4: [native/iOS] initialize database on app start (authored by kamil). · Explain WhyFeb 1 2023, 4:00 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM4e11a2611ec4: [native/iOS] initialize database on app start.

Revision Contents
Changeset List

PathSize
native/
ios/
Comm/
10 lines

Diff 20019

View Options

native/ios/Comm/AppDelegate.mm

Loading...