Page MenuHomePhabricator
Differential D6201

[native] add `clearSensitiveData` to Database Manager
ClosedPublic
Actions

Authored by kamil on Jan 9 2023, 6:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 12:28 AM
Unknown Object (File)
Mon, Nov 4, 3:24 AM
Unknown Object (File)
Fri, Nov 1, 5:33 AM
Unknown Object (File)
Wed, Oct 30, 7:57 AM
Unknown Object (File)
Wed, Oct 30, 7:57 AM
Unknown Object (File)
Wed, Oct 30, 7:57 AM
Unknown Object (File)
Wed, Oct 30, 7:51 AM
Unknown Object (File)
Fri, Oct 18, 3:28 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
marcin
tomek
Commits
rCOMM9d2a81f963e4: [native] add `clearSensitiveData` to Database Manager
Summary

Follow up to D5989. We do not want to use explicit query executor in e.g. CommCoreModule, so hiding this via Database Manager where we have hard coded query executor for now.

Test Plan

Logout to check if database is properly deleted and re-created

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jan 9 2023, 6:46 AM
kamil held this revision as a draft.
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 9 2023, 6:46 AM
kamil added a parent revision: D5989: [native] refactor `clearSensitiveData()` method to static member of `SQLiteQueryExecutor`.Jan 9 2023, 6:47 AM
kamil edited parent revisions, added: D5990: [native] add `.cpp` file for `DatabaseManager`; removed: D5989: [native] refactor `clearSensitiveData()` method to static member of `SQLiteQueryExecutor`.
kamil added a child revision: D5991: [native] add function to initialize `DatabaseQueryExecutor`.
Harbormaster completed remote builds in B15168: Diff 20680.Jan 9 2023, 6:59 AM
kamil published this revision for review.Jan 9 2023, 7:00 AM
marcin accepted this revision.Jan 11 2023, 1:18 AM
marcin added a reviewer: tomek.
tomek accepted this revision.Jan 11 2023, 3:29 AM
This revision is now accepted and ready to land.Jan 11 2023, 3:29 AM
Closed by commit rCOMM9d2a81f963e4: [native] add `clearSensitiveData` to Database Manager (authored by kamil). · Explain WhyJan 27 2023, 5:42 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM9d2a81f963e4: [native] add `clearSensitiveData` to Database Manager.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
1 line
4 lines
NativeModules/
2 lines

Diff 21441

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseManager.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseManager.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...