I have a different understanding of the flow here and how things should cooperate here, so let me ask a few questions to establish a common point of view. Sorry if I am not correct in my understanding.

Is there a premise to implement this functionality in DatabaseManager? We end up calling a method directly from DatabaseManager in CommCoreModule, while in all other places DatabaseManager serves exclusively as a provider of an appropriate query executor.

Do you think that serving query executor is the only responsibility of DatabaseManager?
While working on this I discussed this problem with @tomek and ideally, we should have a third layer above those (right now we have only one database so what we have is sufficient):

• providing database manager eg. some kind of DatabaseProvider class (not present)
• DatabaseManager - providing query executor, managing database, database file and its lifetime, handling initialization etc. (I mentioned the same in D5989's summary)
• QueryExecutor - responsible ONLY for querying the database, operating on its schema using raw SQL or ORM.

This differential and the last two implement some functionality in DatabaseManager, that could be implemented in SQLiteQueryExecutor and exposed to other classes via appropriate virtual methods in DatabaseQueryExecutor.

How checking if database was properly created, and looking into the secure store is connected to the query executor or to be more precise with SQLiteQueryExecutor? What queries it executes, while not doing anything with DB itself but checking Secure Store flag?

Currently we have no plan to replace SQLite with different database type and we can't even try to guess whether we ever will. Moreover, even if one day we need, we might need entirely different functionality than the one implemented in those differential. That said I think it is better to keep methods from last three differentials in more specific, lower-level class (SQLiteContextProvider) and expose them in the same way other methods are.

I got you, and this will make those diffs even easier to implement, but I think by making this we drastically mix responsibilities in this architecture, DatabaseManager only provides an executor- while the query executor does everything, like managing the database...

lower-level class (SQLiteContextProvider) and expose them in the same way other methods are.

Did you mean SQLiteQueryExecutor?

rebase

rebase