Page MenuHomePhabricator
Differential D6001

[native] Add subchannels button
ClosedPublic
Actions

Authored by inka on Dec 22 2022, 8:30 AM.
Tags
None
Referenced Files
F3358845: D6001.id20031.diff
Sun, Nov 24, 6:25 AM
F3358656: D6001.id20317.diff
Sun, Nov 24, 5:42 AM
F3358269: D6001.diff
Sun, Nov 24, 3:51 AM
Unknown Object (File)
Thu, Nov 21, 1:22 PM
Unknown Object (File)
Mon, Nov 4, 11:10 PM
Unknown Object (File)
Mon, Nov 4, 3:20 AM
Unknown Object (File)
Mon, Nov 4, 1:18 AM
Unknown Object (File)
Mon, Oct 28, 8:11 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ginsu
bartek
tomek
Commits
rCOMM50fd4f6c7691: [native] Add subchannels button
Summary

Linear issue: https://linear.app/comm/issue/ENG-2284/add-links-to-subchannels-in-level-2-chats
Add a button that will be used in the community drawer to navigate to the subchannels modal

image.png (82×278 px, 7 KB)

Test Plan

Added it to every community item and saw that pressing it navigates to the subchannels modal

Diff Detail

Repository
rCOMM Comm
Branch
inka/community_drawer
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Dec 22 2022, 8:30 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 22 2022, 8:30 AM
inka edited the summary of this revision. (Show Details)Dec 22 2022, 8:30 AM
Harbormaster completed remote builds in B14691: Diff 20031.Dec 22 2022, 8:39 AM
inka requested review of this revision.Dec 22 2022, 8:39 AM
inka added a child revision: D6002: [native] Add subchannels button to drawer items.Dec 22 2022, 9:22 AM
inka added a reviewer: tomek.Dec 27 2022, 1:38 AM
tomek accepted this revision.Dec 27 2022, 5:11 AM
This revision is now accepted and ready to land.Dec 27 2022, 5:11 AM
inka updated this revision to Diff 20317.Dec 29 2022, 4:08 AM

Rebase

Harbormaster completed remote builds in B14900: Diff 20317.Dec 29 2022, 4:22 AM
Closed by commit rCOMM50fd4f6c7691: [native] Add subchannels button (authored by • InkaSokolowska). · Explain WhyDec 29 2022, 9:26 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMM50fd4f6c7691: [native] Add subchannels button.
inka mentioned this in D6159: [web] Add subchannels button.Jan 4 2023, 5:18 AM
• InkaSokolowska mentioned this in rCOMMfee7aa83830a: [web] Add subchannels button.Feb 14 2023, 5:02 AM

Revision Contents
Changeset List

PathSize
native/
navigation/
63 lines

Diff 20031

View Options

native/navigation/subchannels-button.react.js

Loading...