Page MenuHomePhabricator
Differential D6026

[lib] Introduce `SIWEAuthServerCall` and use as argument for `siweAuth()`
ClosedPublic
Actions

Authored by atul on Dec 24 2022, 7:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 6:58 AM
Unknown Object (File)
Sat, Mar 15, 11:01 PM
Unknown Object (File)
Sat, Mar 15, 11:01 PM
Unknown Object (File)
Sat, Mar 15, 11:01 PM
Unknown Object (File)
Sat, Mar 15, 11:01 PM
Unknown Object (File)
Sat, Mar 15, 11:01 PM
Unknown Object (File)
Sat, Mar 15, 10:48 PM
Unknown Object (File)
Mar 8 2025, 1:05 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMdaa110d42c30: [lib] Introduce `SIWEAuthServerCall` and use as argument for `siweAuth()`
Summary

Introduce the SIWEAuthServerCall type and use as the argument for siweAuth().

We're also updating the return type of the siwe_auth endpoint to boolean for now. The boolean will represent whether or not the nonce, message, and signature in the request are valid and the auth request is "succesful." However, we won't actually register or log in just yet, that will be handled in subsequent diffs (at which point we'll switch from boolean to something like RegisterResponse | LogInResponse).

Depends on D6025

Test Plan

Will be tested implicitly by subsequent diffs... but able to hit endpoint.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D6026 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Dec 24 2022, 7:57 PM
atul edited the summary of this revision. (Show Details)Dec 24 2022, 7:59 PM
atul edited the summary of this revision. (Show Details)
atul added a parent revision: D6025: [lib][keyserver] Introduce `SIWEAuthRequest` and `siweAuthRequestInputValidator`.
atul added a child revision: D6027: [landing] Add `openConnectModal` truthiness check before calling function.
atul edited the summary of this revision. (Show Details)Dec 24 2022, 8:02 PM
Harbormaster completed remote builds in B14736: Diff 20100.Dec 24 2022, 8:11 PM
atul requested review of this revision.Dec 24 2022, 8:11 PM
atul added a child revision: D6028: [native] Modify `SIWEPanel` to hit `siwe_auth` endpoint once SIWE message is signed.Dec 25 2022, 3:45 PM
atul removed a child revision: D6027: [landing] Add `openConnectModal` truthiness check before calling function.
ashoat accepted this revision.Dec 25 2022, 7:23 PM
This revision is now accepted and ready to land.Dec 25 2022, 7:23 PM
atul updated this revision to Diff 20128.EditedDec 27 2022, 12:20 AM

remove address

atul updated this revision to Diff 20129.Dec 27 2022, 12:25 AM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 27 2022, 12:25 AM
Closed by commit rCOMMdaa110d42c30: [lib] Introduce `SIWEAuthServerCall` and use as argument for `siweAuth()` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMdaa110d42c30: [lib] Introduce `SIWEAuthServerCall` and use as argument for `siweAuth()`.
Harbormaster completed remote builds in B14757: Diff 20128.Dec 27 2022, 12:34 AM
Harbormaster completed remote builds in B14758: Diff 20129.Dec 27 2022, 12:38 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
4 lines
lib/
actions/
19 lines
types/
7 lines

Diff 20129

View Options

keyserver/src/responders/user-responders.js

#include "DeviceSessionItem.h" #include "DeviceSessionItem.h"
#include "ConfigManager.h" #include "ConfigManager.h"
#include "Tools.h"
#include <vector>
namespace comm { namespace comm {
namespace network { namespace network {
namespace database { namespace database {
const std::string DeviceSessionItem::FIELD_SESSION_ID = "SessionId"; const std::string DeviceSessionItem::FIELD_SESSION_ID = "SessionId";
const std::string DeviceSessionItem::FIELD_DEVICE_ID = "DeviceId"; const std::string DeviceSessionItem::FIELD_DEVICE_ID = "DeviceId";
const std::string DeviceSessionItem::FIELD_PUBKEY = "PubKey"; const std::string DeviceSessionItem::FIELD_PUBKEY = "PubKey";
Show All 21 Lines : sessionID(sessionID),
deviceOs(deviceOs) { deviceOs(deviceOs) {
this->validate(); this->validate();
} }
DeviceSessionItem::DeviceSessionItem(const AttributeValues &itemFromDB) { DeviceSessionItem::DeviceSessionItem(const AttributeValues &itemFromDB) {
this->assignItemFromDatabase(itemFromDB); this->assignItemFromDatabase(itemFromDB);
} }
void DeviceSessionItem::validate() const { void DeviceSessionItem::validate() const {
maxAuthorUnsubmitted
Done
Inline Actions

Note: SessionID and DeviceID validations were added at the child D3526 diff.

max: Note: SessionID and DeviceID validations were added at the child D3526 diff.
if (!this->sessionID.size()) { checkEmptyField("pubKey", this->pubKey);
throw std::runtime_error("Error: SessionID is empty."); checkEmptyField("notifyToken", this->notifyToken);
} checkEmptyField("deviceType", this->deviceType);
checkEmptyField("appVersion", this->appVersion);
checkEmptyField("deviceOs", this->deviceOs);
} }
void DeviceSessionItem::assignItemFromDatabase( void DeviceSessionItem::assignItemFromDatabase(
const AttributeValues &itemFromDB) { const AttributeValues &itemFromDB) {
try { try {
this->sessionID = itemFromDB.at(DeviceSessionItem::FIELD_SESSION_ID).GetS(); this->sessionID = itemFromDB.at(DeviceSessionItem::FIELD_SESSION_ID).GetS();
this->deviceID = itemFromDB.at(DeviceSessionItem::FIELD_DEVICE_ID).GetS(); this->deviceID = itemFromDB.at(DeviceSessionItem::FIELD_DEVICE_ID).GetS();
this->pubKey = itemFromDB.at(DeviceSessionItem::FIELD_PUBKEY).GetS(); this->pubKey = itemFromDB.at(DeviceSessionItem::FIELD_PUBKEY).GetS();
▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines
View Options

lib/actions/siwe-actions.js

#include "DeviceSessionItem.h" #include "DeviceSessionItem.h"
#include "ConfigManager.h" #include "ConfigManager.h"
#include "Tools.h"
#include <vector>
namespace comm { namespace comm {
namespace network { namespace network {
namespace database { namespace database {
const std::string DeviceSessionItem::FIELD_SESSION_ID = "SessionId"; const std::string DeviceSessionItem::FIELD_SESSION_ID = "SessionId";
const std::string DeviceSessionItem::FIELD_DEVICE_ID = "DeviceId"; const std::string DeviceSessionItem::FIELD_DEVICE_ID = "DeviceId";
const std::string DeviceSessionItem::FIELD_PUBKEY = "PubKey"; const std::string DeviceSessionItem::FIELD_PUBKEY = "PubKey";
Show All 21 Lines : sessionID(sessionID),
deviceOs(deviceOs) { deviceOs(deviceOs) {
this->validate(); this->validate();
} }
DeviceSessionItem::DeviceSessionItem(const AttributeValues &itemFromDB) { DeviceSessionItem::DeviceSessionItem(const AttributeValues &itemFromDB) {
this->assignItemFromDatabase(itemFromDB); this->assignItemFromDatabase(itemFromDB);
} }
void DeviceSessionItem::validate() const { void DeviceSessionItem::validate() const {
maxAuthorUnsubmitted
Done
Inline Actions

Note: SessionID and DeviceID validations were added at the child D3526 diff.

max: Note: SessionID and DeviceID validations were added at the child D3526 diff.
if (!this->sessionID.size()) { checkEmptyField("pubKey", this->pubKey);
throw std::runtime_error("Error: SessionID is empty."); checkEmptyField("notifyToken", this->notifyToken);
} checkEmptyField("deviceType", this->deviceType);
checkEmptyField("appVersion", this->appVersion);
checkEmptyField("deviceOs", this->deviceOs);
} }
void DeviceSessionItem::assignItemFromDatabase( void DeviceSessionItem::assignItemFromDatabase(
const AttributeValues &itemFromDB) { const AttributeValues &itemFromDB) {
try { try {
this->sessionID = itemFromDB.at(DeviceSessionItem::FIELD_SESSION_ID).GetS(); this->sessionID = itemFromDB.at(DeviceSessionItem::FIELD_SESSION_ID).GetS();
this->deviceID = itemFromDB.at(DeviceSessionItem::FIELD_DEVICE_ID).GetS(); this->deviceID = itemFromDB.at(DeviceSessionItem::FIELD_DEVICE_ID).GetS();
this->pubKey = itemFromDB.at(DeviceSessionItem::FIELD_PUBKEY).GetS(); this->pubKey = itemFromDB.at(DeviceSessionItem::FIELD_PUBKEY).GetS();
▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines
View Options

lib/types/siwe-types.js

#include "DeviceSessionItem.h" #include "DeviceSessionItem.h"
#include "ConfigManager.h" #include "ConfigManager.h"
#include "Tools.h"
#include <vector>
namespace comm { namespace comm {
namespace network { namespace network {
namespace database { namespace database {
const std::string DeviceSessionItem::FIELD_SESSION_ID = "SessionId"; const std::string DeviceSessionItem::FIELD_SESSION_ID = "SessionId";
const std::string DeviceSessionItem::FIELD_DEVICE_ID = "DeviceId"; const std::string DeviceSessionItem::FIELD_DEVICE_ID = "DeviceId";
const std::string DeviceSessionItem::FIELD_PUBKEY = "PubKey"; const std::string DeviceSessionItem::FIELD_PUBKEY = "PubKey";
Show All 21 Lines : sessionID(sessionID),
deviceOs(deviceOs) { deviceOs(deviceOs) {
this->validate(); this->validate();
} }
DeviceSessionItem::DeviceSessionItem(const AttributeValues &itemFromDB) { DeviceSessionItem::DeviceSessionItem(const AttributeValues &itemFromDB) {
this->assignItemFromDatabase(itemFromDB); this->assignItemFromDatabase(itemFromDB);
} }
void DeviceSessionItem::validate() const { void DeviceSessionItem::validate() const {
maxAuthorUnsubmitted
Done
Inline Actions

Note: SessionID and DeviceID validations were added at the child D3526 diff.

max: Note: SessionID and DeviceID validations were added at the child D3526 diff.
if (!this->sessionID.size()) { checkEmptyField("pubKey", this->pubKey);
throw std::runtime_error("Error: SessionID is empty."); checkEmptyField("notifyToken", this->notifyToken);
} checkEmptyField("deviceType", this->deviceType);
checkEmptyField("appVersion", this->appVersion);
checkEmptyField("deviceOs", this->deviceOs);
} }
void DeviceSessionItem::assignItemFromDatabase( void DeviceSessionItem::assignItemFromDatabase(
const AttributeValues &itemFromDB) { const AttributeValues &itemFromDB) {
try { try {
this->sessionID = itemFromDB.at(DeviceSessionItem::FIELD_SESSION_ID).GetS(); this->sessionID = itemFromDB.at(DeviceSessionItem::FIELD_SESSION_ID).GetS();
this->deviceID = itemFromDB.at(DeviceSessionItem::FIELD_DEVICE_ID).GetS(); this->deviceID = itemFromDB.at(DeviceSessionItem::FIELD_DEVICE_ID).GetS();
this->pubKey = itemFromDB.at(DeviceSessionItem::FIELD_PUBKEY).GetS(); this->pubKey = itemFromDB.at(DeviceSessionItem::FIELD_PUBKEY).GetS();
▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines