Page MenuHomePhabricator

[keyserver] Introduce `isValidSIWEMessage` and use it to validate `message` in `siweAuthResponder`
ClosedPublic

Authored by atul on Dec 24 2022, 7:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 5:22 AM
Unknown Object (File)
Fri, Nov 8, 4:18 PM
Unknown Object (File)
Fri, Nov 8, 4:18 PM
Unknown Object (File)
Fri, Nov 8, 4:18 PM
Unknown Object (File)
Fri, Nov 8, 4:18 PM
Unknown Object (File)
Fri, Nov 8, 3:48 PM
Unknown Object (File)
Fri, Nov 8, 3:48 PM
Unknown Object (File)
Tue, Nov 5, 4:20 AM
Subscribers
None

Details

Summary

Check that the values in SIWEMessage are as expected. Throw a ServerError in siweAuthResponder if not.


Depends on D6030

Test Plan

Tried calling the endpoint with various inputs (correct and malformed). Set breakpoints throughout and ensured that things worked as expected.

Also moved siweStatement to lib so it could be shared outside of native.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D6031 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul requested review of this revision.Dec 24 2022, 8:13 PM
This revision is now accepted and ready to land.Dec 25 2022, 7:25 PM
This revision was landed with ongoing or failed builds.Dec 27 2022, 12:52 AM
This revision was automatically updated to reflect the committed changes.