introduce the message like button to message tooltips. Will be syncing with @tomek about landing these changes since he is also working in tooltip-utils for the copy button on the tooltip. I handled the merge conflicts and rebased the copy button code in with the react button code in this diff.
Details
Details
Please watch the demo video to see the changes I made:
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- eng-2464 (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Will be syncing with @tomek about landing these changes since he is also working in tooltip-utils for the copy button on the tooltip.
The only thing we should synchronize is the ordering of the buttons. Other than that the diffs could be landed in any order and there shouldn't be significant conflicts.
| web/utils/tooltip-utils.js | ||
|---|---|---|
| 422 ↗ | (On Diff #20258) | We can transform this to boolean here instead of when rendering |
| 442–444 ↗ | (On Diff #20258) | When a lambda has the same parameter as the only function called inside it, you should be able to simply use the inner function instead. If that's not possible due to Flow, it means that we typed a callback as returning void instead of mixed. We should always prefer mixed when we don't care about the result to make our api more convenient to use. |
| 452 ↗ | (On Diff #20258) | |