Introduce isValidSIWEStatementWithPublicKey(...) to check if SIWE statement is valid statement that includes the Device IdPubKey as described in the whitepaper: https://blob.sh/a3d138.png
Depends on D6129
Details
Details
included a unit test (will include more later)
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- arcpatch-D6130 (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/utils/siwe-utils.js | ||
|---|---|---|
| 53 ↗ | (On Diff #20479) | Yes, this is a long line that exceeds the 80 character width limit. Saw that there are ways to split a regex across multiple lines on StackOverflow (https://stackoverflow.com/questions/12317049/how-to-split-a-long-regular-expression-into-multiple-lines-in-javascript), but the solutions didn't seem as clean and there were some "gotchas." Open to any suggestions. |
| lib/utils/siwe-utils.js | ||
|---|---|---|
| 53 ↗ | (On Diff #20479) | Eh whatever. We do this in other places with JS RegExp literals in the codebase, like lib/shared/markdown.js Can you update this to have a newline? |
| lib/utils/siwe-utils.js | ||
|---|---|---|
| 53 ↗ | (On Diff #20479) | SIWE spec prohibits newlines in statement field |