Page MenuHomePhabricator
Differential D6169

[keyserver] rename node addon
ClosedPublic
Actions

Authored by varun on Jan 4 2023, 11:53 AM.
Tags
None
Referenced Files
F3384913: D6169.id20641.diff
Thu, Nov 28, 10:37 PM
Unknown Object (File)
Thu, Nov 28, 4:06 AM
Unknown Object (File)
Thu, Nov 28, 4:06 AM
Unknown Object (File)
Tue, Nov 26, 10:30 AM
Unknown Object (File)
Tue, Nov 26, 8:45 AM
Unknown Object (File)
Mon, Nov 4, 9:31 AM
Unknown Object (File)
Mon, Nov 4, 9:30 AM
Unknown Object (File)
Mon, Nov 4, 9:29 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
• max
Commits
rCOMM80f5fbfa0321: [keyserver] rename node addon
Summary

we plan to use this node addon for more than just exposing opaque-ke, so we should rename it to something more generic.

Test Plan

yarn cleaninstall

Diff Detail

Repository
rCOMM Comm
Branch
new-master (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Jan 4 2023, 11:53 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptJan 4 2023, 11:53 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 4 2023, 11:58 AM
Harbormaster failed remote builds in B15091: Diff 20583!
varun updated this revision to Diff 20584.Jan 4 2023, 12:09 PM

fix symlink

Harbormaster completed remote builds in B15092: Diff 20584.Jan 4 2023, 12:21 PM
varun requested review of this revision.Jan 4 2023, 12:21 PM
• max accepted this revision.Jan 5 2023, 2:39 AM

As we are going to use a unified rust library for the gRPC client, looks good to me to make these changes.

tomek accepted this revision.Jan 5 2023, 7:10 AM
tomek added inline comments.
keyserver/src/rust-node-addon
2

Can we add a newline here?

This revision is now accepted and ready to land.Jan 5 2023, 7:10 AM
ashoat added inline comments.Jan 5 2023, 4:11 PM
keyserver/src/rust-node-addon
2

I think this is a symlink

varun added inline comments.Jan 5 2023, 8:51 PM
keyserver/src/rust-node-addon
2

that's right

Closed by commit rCOMM80f5fbfa0321: [keyserver] rename node addon (authored by varun). · Explain WhyJan 6 2023, 8:41 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM80f5fbfa0321: [keyserver] rename node addon.

Revision Contents
Changeset List

PathSize
keyserver/
14 lines
addons/
opaque-ke-napi/
src/
rust-node-addon/
opaque-ke-napi/
3 lines
2 lines
5 lines
8 lines
4 lines
src/
9 lines
2 lines
2 lines
src/
1 line
4 lines

Diff 20584

View Options

keyserver/Dockerfile

Loading...
View Options

keyserver/addons/opaque-ke-napi/.gitignore

Loading...
View Options

keyserver/addons/opaque-ke-napi/Cargo.toml

Loading...
View Options

keyserver/addons/opaque-ke-napi/build.rs

Loading...
View Options

keyserver/addons/opaque-ke-napi/index.js

Loading...
View Options

keyserver/addons/opaque-ke-napi/package.json

Loading...
View Options

keyserver/addons/opaque-ke-napi/src/lib.rs

Loading...
View Options

keyserver/addons/rust-node-addon/.gitignore

Loading...
View Options

keyserver/addons/rust-node-addon/Cargo.toml

Loading...
View Options

keyserver/addons/rust-node-addon/build.rs

Loading...
View Options

keyserver/addons/rust-node-addon/index.js

Loading...
View Options

keyserver/addons/rust-node-addon/package.json

Loading...
View Options

keyserver/addons/rust-node-addon/src/lib.rs

Loading...
View Options

keyserver/loader.mjs

Loading...
View Options

keyserver/package.json

Loading...
View Options

keyserver/src/opaque-ke-napi

Loading...
View Options

keyserver/src/rust-node-addon

Loading...
View Options

package.json

Loading...