Page MenuHomePhabricator
Differential D6191

[Services] Lint list_services.sh
ClosedPublic
Actions

Authored by • jon on Jan 6 2023, 3:23 PM.
Tags
None
Referenced Files
F3527261: D6191.id20645.diff
Tue, Dec 24, 4:25 AM
F3525215: D6191.diff
Mon, Dec 23, 4:01 PM
Unknown Object (File)
Sat, Nov 30, 10:10 AM
Unknown Object (File)
Sat, Nov 30, 10:10 AM
Unknown Object (File)
Sat, Nov 30, 10:10 AM
Unknown Object (File)
Thu, Nov 28, 10:37 PM
Unknown Object (File)
Nov 22 2024, 4:10 AM
Unknown Object (File)
Nov 22 2024, 4:10 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
varun
bartek
• max
Commits
rCOMMc065453eb143: [Services] Lint list_services.sh
Summary

To make the later fix easier to review, decided to lint this file.

Test Plan

N/A, only \ and new lines were added

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Jan 6 2023, 3:23 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 6 2023, 3:23 PM
• jon added a child revision: D6192: [Services] Use GNU + BSD compatible find command.Jan 6 2023, 3:27 PM
Harbormaster completed remote builds in B15139: Diff 20645.Jan 6 2023, 3:38 PM
• jon requested review of this revision.Jan 6 2023, 3:38 PM
bartek accepted this revision.Jan 6 2023, 11:07 PM

How did you lint this file? Was it formatted manually or is there some auto-formatter? I don't see such option in shellcheck.

This revision is now accepted and ready to land.Jan 6 2023, 11:07 PM
ashoat added a comment.Jan 7 2023, 10:02 AM

I think he means manually

• jon added a comment.Jan 9 2023, 12:21 PM

I think he means manually

Yep, just used a vim macro to record it once, then did 8@<macro key>

Closed by commit rCOMMc065453eb143: [Services] Lint list_services.sh (authored by • jon). · Explain WhyJan 9 2023, 12:22 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMc065453eb143: [Services] Lint list_services.sh.

Revision Contents
Changeset List

PathSize
services/
scripts/
12 lines

Diff 20645

View Options

services/scripts/list_services.sh

Loading...