Page MenuHomePhabricator
Differential D6309

[native] Fix 'expo' command in nix env
ClosedPublic
Actions

Authored by bartek on Jan 19 2023, 4:04 AM.
Tags
None
Referenced Files
F3506044: D6309.id21078.diff
Fri, Dec 20, 3:33 PM
F3505078: D6309.diff
Fri, Dec 20, 12:05 PM
Unknown Object (File)
Nov 1 2024, 3:25 PM
Unknown Object (File)
Oct 30 2024, 2:25 AM
Unknown Object (File)
Oct 30 2024, 2:25 AM
Unknown Object (File)
Oct 30 2024, 2:25 AM
Unknown Object (File)
Oct 30 2024, 2:22 AM
Unknown Object (File)
Oct 26 2024, 4:42 PM
View All 61 Files
Subscribers
tomek

Details

Reviewers
ashoat
atul
• jon
Commits
rCOMM653695092fee: [native] Fix 'expo' command in nix env
Summary

Analogous to D5508. I use the expo run:android instead of react-native run-android (see why) and it fails in Nix workflow. The solution is to do the same as in D5508.

I also added the run-ios and run-android scripts, because the COMM_DEV env should be provided when opening Metro bundler (and these commands do this unless already started or the --no-bundler flag is provided).

Test Plan
  • yarn dev still works the same way
  • expo run:ios builds the native app successfully
  • the same for expo run:android

Diff Detail

Repository
rCOMM Comm
Branch
barthap/expo-commands
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Jan 19 2023, 4:04 AM
bartek held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptJan 19 2023, 4:04 AM
Harbormaster completed remote builds in B15458: Diff 21078.Jan 19 2023, 4:18 AM
bartek added 2 blocking reviewer(s): ashoat, atul.Jan 20 2023, 12:24 AM
bartek published this revision for review.Jan 20 2023, 12:26 AM
bartek added inline comments.
native/package.json
23

I'd move COMM_DEV here UNLESS the expo command is used somewhere during the release process, cc @atul
In this case I wouldn't add the run-ios and run-android scripts

bartek mentioned this in D6319: [native] Add URI scheme to debug Info.plist.Jan 20 2023, 3:35 AM
• jon accepted this revision.Jan 20 2023, 8:27 AM

If they need access to the macOS native version of clang, this makes sense.

Not sure about COMM_DEV usage, but will defer to someone else on it.

atul added inline comments.Jan 20 2023, 5:16 PM
native/package.json
23

Nope! Not part of the release process

atul accepted this revision.Jan 20 2023, 5:16 PM
ashoat accepted this revision.Jan 20 2023, 5:30 PM
This revision is now accepted and ready to land.Jan 20 2023, 5:30 PM
bartek mentioned this in rCOMMc78260547876: [native] Add URI scheme to debug Info.plist.Jan 23 2023, 7:18 AM
Closed by commit rCOMM653695092fee: [native] Fix 'expo' command in nix env (authored by bartek). · Explain WhyJan 31 2023, 2:24 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM653695092fee: [native] Fix 'expo' command in nix env.

Revision Contents
Changeset List

PathSize
native/
5 lines

Diff 21078

View Options

native/package.json

Loading...