Page MenuHomePhabricator
Differential D6388

[blob][backup] Remove blob_hash from log span
ClosedPublic
Actions

Authored by bartek on Jan 25 2023, 2:38 AM.
Tags
None
Referenced Files
F3350114: D6388.id21302.diff
Fri, Nov 22, 8:49 PM
F3349118: D6388.diff
Fri, Nov 22, 5:15 PM
Unknown Object (File)
Sun, Nov 10, 2:00 PM
Unknown Object (File)
Fri, Nov 8, 5:02 AM
Unknown Object (File)
Fri, Nov 8, 4:52 AM
Unknown Object (File)
Thu, Nov 7, 5:38 PM
Unknown Object (File)
Oct 2 2024, 6:44 PM
Unknown Object (File)
Sep 27 2024, 9:09 AM
View All 59 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
varun
• jon
• max
Commits
rCOMM61d0bd31fe13: [blob][backup] Remove blob_hash from log span
Summary

When testing D6387, I was overwhelmed by log span metadata fields. The blob hash is very long and takes too much space when displayed with every tracing log message.
I replaced it to be displayed only once when received.

Test Plan

Both services start and display logs correctly

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Jan 25 2023, 2:38 AM
bartek held this revision as a draft.
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 25 2023, 2:38 AM
Harbormaster completed remote builds in B15628: Diff 21302.Jan 25 2023, 2:49 AM
bartek published this revision for review.Jan 25 2023, 2:49 AM
• max added inline comments.Jan 25 2023, 5:33 AM
services/backup/src/service/handlers/create_backup.rs
106

I think hash is a part of sensitive data that should not be logged in any case, but I'm not sure what the decision was made to debug this service. If this is for the local debug only, maybe we should remove this logging.

ashoat added a comment.Jan 25 2023, 6:28 AM

Blob hash is probably fine to log, since it's not tied to a specific user

• max accepted this revision.Jan 26 2023, 7:52 AM
This revision is now accepted and ready to land.Jan 26 2023, 7:52 AM
Closed by commit rCOMM61d0bd31fe13: [blob][backup] Remove blob_hash from log span (authored by bartek). · Explain WhyJan 31 2023, 2:23 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM61d0bd31fe13: [blob][backup] Remove blob_hash from log span.

Revision Contents
Changeset List

PathSize
services/
backup/
src/
service/
handlers/
2 lines
2 lines
4 lines
blob/
src/
4 lines

Diff 21302

View Options

services/backup/src/service/handlers/create_backup.rs

Loading...
View Options

services/backup/src/service/handlers/send_log.rs

Loading...
View Options

services/backup/src/service/mod.rs

Loading...
View Options

services/blob/src/service.rs

Loading...