[web] switch like button to react button on message tooltip
ClosedPublic
Actions

Authored by ginsu on Jan 26 2023, 12:01 PM.

Details

Reviewers

atul
tomek

Commits

rCOMM639e994c1bbf: [web] switch like button to react button on message tooltip

Summary

Introduced the emoji keyboard and make it render whenever renderEmojiKeyboard in the tooltip context is set to true. Also modified useMessageReactAction to return a react button instead of a like button. Will be working on improving the positioning of the emoji keyboard in a subsequent diff

Depends on D6401
Linear Task: ENG-2778

Test Plan

Please watch the video below to see a demo of how the new react button works

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Jan 26 2023, 12:01 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 26 2023, 12:01 PM

ginsu edited the summary of this revision. (Show Details)Jan 26 2023, 12:12 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added a parent revision: D6401: [web] modify useOnClickReact to return function with arguments instead of passing arguments directly into hook.

ginsu added reviewers: atul, tomek.

ginsu attached a referenced file: F346108: Screen Recording 2023-01-26 at 3.11.10 PM.mov. (Show Details)

ginsu added a child revision: D6403: [web] remove message like tooltip button component.Jan 26 2023, 12:15 PM

Harbormaster completed remote builds in B15684: Diff 21386.Jan 26 2023, 12:15 PM

ginsu requested review of this revision.Jan 26 2023, 12:15 PM

Looks good, left a couple of notes inline

web/chat/message-tooltip.react.js
116–117 ↗	(On Diff #21386)	Looks like this pattern is used a couple times in the codebase. Wonder if it would make sense to factor out? Outside the scope of this diff though.
119 ↗	(On Diff #21386)	The naming here is kind of confusing because it doesn't get trigged "`onClick`" anymore? Do you think there's a more descriptive name we can use here?
147–150 ↗	(On Diff #21386)	Personally prefer this sort of thing to keep things symmetric, but up to you.
152–159 ↗	(On Diff #21386)