[blob][backup] Remove blob_hash from log span
ClosedPublic
Actions

Authored by bartek on Jan 25 2023, 2:38 AM.

Details

Reviewers

varun
• jon
• max

Commits

rCOMM61d0bd31fe13: [blob][backup] Remove blob_hash from log span

Summary

When testing D6387, I was overwhelmed by log span metadata fields. The blob hash is very long and takes too much space when displayed with every tracing log message.
I replaced it to be displayed only once when received.

Test Plan

Both services start and display logs correctly

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jan 25 2023, 2:38 AM

bartek held this revision as a draft.

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 25 2023, 2:38 AM

Harbormaster completed remote builds in B15628: Diff 21302.Jan 25 2023, 2:49 AM

bartek published this revision for review.Jan 25 2023, 2:49 AM

• max added inline comments.Jan 25 2023, 5:33 AM

services/backup/src/service/handlers/create_backup.rs
106 ↗	(On Diff #21302)	I think hash is a part of sensitive data that should not be logged in any case, but I'm not sure what the decision was made to debug this service. If this is for the local debug only, maybe we should remove this logging.