Page MenuHomePhabricator
Differential D6481

[web] Change `modal_body` colors in `log-in-form.css`
ClosedPublic
Actions

Authored by atul on Jan 31 2023, 10:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 28, 10:08 PM
Unknown Object (File)
Nov 15 2024, 9:51 PM
Unknown Object (File)
Nov 15 2024, 6:26 PM
Unknown Object (File)
Nov 10 2024, 12:09 AM
Unknown Object (File)
Nov 9 2024, 11:21 PM
Unknown Object (File)
Nov 9 2024, 9:43 PM
Unknown Object (File)
Nov 9 2024, 7:31 PM
Unknown Object (File)
Nov 9 2024, 1:17 PM
View All 89 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
ginsu
rohan
Commits
rCOMMaa8960579695: [web] Change `modal_body` colors in `log-in-form.css`
Summary

Modify modal_body colors and replace outer glow with outline to match the SIWE web designs (https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=7646%3A134916&t=6T70eVfC0cqPSbXJ-1)

Test Plan

Before:

a8dea2.png (770×802 px, 87 KB)

After:

31549e.png (896×808 px, 53 KB)

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D6481_1 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jan 31 2023, 10:22 AM
atul published this revision for review.Jan 31 2023, 10:23 AM
atul added inline comments.
web/account/log-in-form.css
6 ↗(On Diff #21694)

modal-bg is used in a couple places so I didn't want to just swap it out (thought I think we totally could).

Going to just use hard-coded hex values for now, but happy to work with David to reconcile new colors with old design system (defined in theme.css) after this SIWE web stuff is done... think it should just take a day or two.

atul edited the test plan for this revision. (Show Details)Jan 31 2023, 10:24 AM
atul added reviewers: ginsu, rohan.
atul edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B15893: Diff 21694.Jan 31 2023, 10:34 AM
atul added a child revision: D6483: [web] Update `Button` colors in `LogInForm`.Jan 31 2023, 10:35 AM
ashoat accepted this revision.Jan 31 2023, 12:07 PM
This revision is now accepted and ready to land.Jan 31 2023, 12:07 PM
atul abandoned this revision.Jan 31 2023, 12:37 PM
ashoat added a comment.Jan 31 2023, 1:38 PM

(I think the glow should be removed regardless of decisions on colors)

atul reclaimed this revision.Feb 2 2023, 12:42 PM
This revision is now accepted and ready to land.Feb 2 2023, 12:42 PM
atul updated this revision to Diff 21901.Feb 2 2023, 12:42 PM
atul edited the test plan for this revision. (Show Details)

re-open and rebase

This revision was landed with ongoing or failed builds.Feb 2 2023, 12:44 PM
Closed by commit rCOMMaa8960579695: [web] Change `modal_body` colors in `log-in-form.css` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMaa8960579695: [web] Change `modal_body` colors in `log-in-form.css`.
Harbormaster completed remote builds in B16029: Diff 21901.Feb 2 2023, 12:57 PM

Revision Contents
Changeset List

PathSize
web/
account/
4 lines
2 lines

Diff 21901

View Options

web/account/log-in-form.css

Loading...
View Options

web/account/siwe.css

Loading...