[lib] Migrate DeleteEntry/RestoreEntry notifTexts to use EntityText
ClosedPublic
Actions

Authored by ashoat on Feb 4 2023, 10:03 AM.

Details

Reviewers

atul

Commits

rCOMM6a0eaee4cec8: [lib] Migrate DeleteEntry/RestoreEntry notifTexts to use EntityText

Summary

Depends on D6576

Test Plan

Generated DeleteEntry and RestoreEntry messages on a web client in a chat with a different test user that is logged in on the iOS simulator. Background the iOS app and make sure the notif looks right

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 4 2023, 10:03 AM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 4 2023, 10:03 AM

ashoat added a child revision: D6578: [lib] Migrate CreateThread/CreateSubThread notifTexts to use EntityText.Feb 4 2023, 10:03 AM

Harbormaster completed remote builds in B16091: Diff 21978.Feb 4 2023, 10:17 AM

ashoat requested review of this revision.Feb 4 2023, 10:17 AM

atul accepted this revision.Feb 4 2023, 11:34 AM

This revision is now accepted and ready to land.Feb 4 2023, 11:34 AM

Closed by commit rCOMM6a0eaee4cec8: [lib] Migrate DeleteEntry/RestoreEntry notifTexts to use EntityText (authored by ashoat). · Explain WhyFeb 5 2023, 8:01 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM6a0eaee4cec8: [lib] Migrate DeleteEntry/RestoreEntry notifTexts to use EntityText.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

delete-entry-message-spec.js

23 lines

restore-entry-message-spec.js

23 lines

Diff 21978

View Options

lib/shared/messages/delete-entry-message-spec.js