[lib] Migrate Text notifText to use EntityText
ClosedPublic
Actions

Authored by ashoat on Feb 4 2023, 10:05 AM.

Tags

None

Referenced Files

	F3504343: D6581.diff
	Fri, Dec 20, 8:40 AM

	Unknown Object (File)
	Nov 18 2024, 7:34 PM

	Unknown Object (File)
	Oct 26 2024, 9:22 PM

	Unknown Object (File)
	Oct 26 2024, 9:22 PM

	Unknown Object (File)
	Oct 26 2024, 9:21 PM

	Unknown Object (File)
	Oct 26 2024, 9:14 PM

	Unknown Object (File)
	Oct 12 2024, 10:16 PM

	Unknown Object (File)
	Oct 1 2024, 4:09 AM

View All 68 Files

Subscribers

tomek

Details

Reviewers

atul

Commits

rCOMM10553f5bca78: [lib] Migrate Text notifText to use EntityText

Summary

Depends on D6580

Test Plan

Generated text message on a web client in a chat with a different test user that is logged in on the iOS simulator. Background the iOS app and make sure the notif looks right

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 4 2023, 10:05 AM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 4 2023, 10:05 AM

ashoat added a child revision: D6582: [lib] Migrate UpdateRelationship notifText to use EntityText.Feb 4 2023, 10:05 AM

Harbormaster completed remote builds in B16095: Diff 21987.Feb 4 2023, 10:21 AM

ashoat requested review of this revision.Feb 4 2023, 10:21 AM

atul accepted this revision.Feb 4 2023, 11:58 AM

This revision is now accepted and ready to land.Feb 4 2023, 11:58 AM

Closed by commit rCOMM10553f5bca78: [lib] Migrate Text notifText to use EntityText (authored by ashoat). · Explain WhyFeb 5 2023, 8:01 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM10553f5bca78: [lib] Migrate Text notifText to use EntityText.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

text-message-spec.js

14 lines

Diff 21987

View Options

lib/shared/messages/text-message-spec.js

[lib] Migrate Text notifText to use EntityTextClosedPublicActions