[lib] Migrate UpdateRelationship notifText to use EntityText
ClosedPublic
Actions

Authored by ashoat on Feb 4 2023, 10:05 AM.

Details

Reviewers

atul

Commits

rCOMM53c777b2c79f: [lib] Migrate UpdateRelationship notifText to use EntityText

Summary

Depends on D6581

Test Plan

Generated UpdateRelationship message on a web client in a chat with a different test user that is logged in on the iOS simulator. Background the iOS app and make sure the notif looks right

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 4 2023, 10:05 AM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 4 2023, 10:05 AM

ashoat added a child revision: D6583: [lib] Migrate Reaction notifText to use EntityText.Feb 4 2023, 10:05 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 4 2023, 10:19 AM

Harbormaster failed remote builds in B16096: Diff 21988!

Harbormaster completed remote builds in B16096: Diff 21988.Feb 4 2023, 10:40 AM

ashoat requested review of this revision.Feb 4 2023, 10:40 AM

atul accepted this revision.Feb 4 2023, 11:59 AM

This revision is now accepted and ready to land.Feb 4 2023, 11:59 AM

Closed by commit rCOMM53c777b2c79f: [lib] Migrate UpdateRelationship notifText to use EntityText (authored by ashoat). · Explain WhyFeb 5 2023, 8:01 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM53c777b2c79f: [lib] Migrate UpdateRelationship notifText to use EntityText.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

update-relationship-message-spec.js

6 lines

Diff 21988

View Options

lib/shared/messages/update-relationship-message-spec.js

[lib] Migrate UpdateRelationship notifText to use EntityTextClosedPublicActions