[lib] Migrate Multimedia notifText to use EntityText
ClosedPublic
Actions

Authored by ashoat on Feb 4 2023, 10:06 AM.

Details

Reviewers

atul

Commits

rCOMM2c775ad1868b: [lib] Migrate Multimedia notifText to use EntityText

Summary

Depends on D6583

Test Plan

Generated Multimedia message on a web client in a chat with a different test user that is logged in on the iOS simulator. Background the iOS app and make sure the notif looks right

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 4 2023, 10:06 AM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 4 2023, 10:06 AM

ashoat added a child revision: D6585: [lib] Stop passing notifThreadName to notificationTexts.Feb 4 2023, 10:06 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 4 2023, 12:09 PM

Harbormaster failed remote builds in B16098: Diff 21990!

Harbormaster completed remote builds in B16098: Diff 21990.Feb 4 2023, 12:19 PM

ashoat requested review of this revision.Feb 4 2023, 12:19 PM

atul accepted this revision.Feb 4 2023, 2:23 PM

This revision is now accepted and ready to land.Feb 4 2023, 2:23 PM

Closed by commit rCOMM2c775ad1868b: [lib] Migrate Multimedia notifText to use EntityText (authored by ashoat). · Explain WhyFeb 5 2023, 8:01 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM2c775ad1868b: [lib] Migrate Multimedia notifText to use EntityText.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

multimedia-message-spec.js

13 lines

Diff 21990

View Options

lib/shared/messages/multimedia-message-spec.js

[lib] Migrate Multimedia notifText to use EntityTextClosedPublicActions