Page MenuHomePhabricator

[services] Tunnelbroker - Extracting `deleteQueueIfEmpty` logic to a separate function
ClosedPublic

Authored by max on Feb 6 2023, 4:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 12:37 AM
Unknown Object (File)
Sat, Oct 26, 9:55 PM
Unknown Object (File)
Oct 13 2024, 9:08 PM
Unknown Object (File)
Sep 30 2024, 4:53 PM
Unknown Object (File)
Sep 30 2024, 4:53 PM
Unknown Object (File)
Sep 30 2024, 4:53 PM
Unknown Object (File)
Sep 30 2024, 4:53 PM
Unknown Object (File)
Sep 30 2024, 4:51 PM
Subscribers

Details

Summary

This diff introduces extracting the deleteQueueIfEmpty calling for the DeliveryBroker into a separate function to call it in the following D6626 from the Rust gRPC handler.
The reason for extracting is disabling messages persisting in the DynamoDB database by the config flag introduced in the D6622. In the following D6626, we will call deleteQueueIfEmpty function, but skip to remove the messages from the database if the config flag from D6622 is presented.

Linear task: ENG-2641

Test Plan
  1. CI gates are passed.
  2. Manual testing should be performed on the following D6626 diff.

Diff Detail

Repository
rCOMM Comm
Branch
extract-deleteQueueIfEmpty
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

max held this revision as a draft.
max edited the test plan for this revision. (Show Details)
max added a reviewer: bartek.
max published this revision for review.Feb 6 2023, 5:46 AM
This revision is now accepted and ready to land.Feb 7 2023, 9:02 AM

Rebasing on master and parent changes.